Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add string trim for PrivValidatorListenAddr string #768

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Mar 18, 2024

Description

  • (Audit issue) add TrimSpace for the string value of PrivValidatorListenAddr
    • Potential problem:
      • The configuration is utilized to ascertain the remote Key Management Service (KMS) through the PrivValidatorListenAddr, which is in string format loaded from the config TOML file. However, it currently lacks a space trim.

@jaeseung-bae jaeseung-bae self-assigned this Mar 18, 2024
@jaeseung-bae jaeseung-bae marked this pull request as ready for review March 18, 2024 01:00
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.54%. Comparing base (1279868) to head (3d05d06).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #768      +/-   ##
==========================================
+ Coverage   66.52%   66.54%   +0.01%     
==========================================
  Files         285      285              
  Lines       37917    37917              
==========================================
+ Hits        25224    25231       +7     
+ Misses      10887    10885       -2     
+ Partials     1806     1801       -5     
Files Coverage Δ
cmd/ostracon/commands/show_validator.go 72.72% <100.00%> (ø)
node/node.go 61.49% <100.00%> (ø)

... and 11 files with indirect coverage changes

@ulbqb
Copy link
Member

ulbqb commented Mar 18, 2024

if config.PrivValidatorListenAddr != "" {

Should this be fixed too?

@ulbqb
Copy link
Member

ulbqb commented Mar 18, 2024

Please add issue detail.

@jaeseung-bae
Copy link
Contributor Author

if config.PrivValidatorListenAddr != "" {

Should this be fixed too?

It has been fixed(3d05d06bdb76f5b0e278930564f1a60be4060cec)

@jaeseung-bae jaeseung-bae added C: bug Classification: Something isn't working C: enhancement Classification: New feature or its request, or improvement in maintainability of code and removed C: bug Classification: Something isn't working labels Mar 18, 2024
@jaeseung-bae jaeseung-bae merged commit e1be3c4 into Finschia:main Mar 19, 2024
23 checks passed
@jaeseung-bae jaeseung-bae deleted the fix/config-priv-val-addr branch March 19, 2024 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants