Skip to content
This repository has been archived by the owner on Apr 24, 2023. It is now read-only.

feat: Name & WriteLowPri methods #35

Merged
merged 12 commits into from
Jan 21, 2022
Merged

feat: Name & WriteLowPri methods #35

merged 12 commits into from
Jan 21, 2022

Conversation

iproudhon
Copy link
Contributor

Added Name() for easier debugging & and WriteLowPri() for pruning.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2022

Codecov Report

Merging #35 (0fe06fc) into main (fcfa67d) will increase coverage by 13.08%.
The diff coverage is 64.63%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
+ Coverage   52.60%   65.69%   +13.08%     
===========================================
  Files          29       32        +3     
  Lines        1785     1402      -383     
===========================================
- Hits          939      921       -18     
+ Misses        740      420      -320     
+ Partials      106       61       -45     
Impacted Files Coverage Δ
badgerdb/batch.go 96.15% <0.00%> (-3.85%) ⬇️
boltdb/batch.go 80.55% <0.00%> (-2.31%) ⬇️
cleveldb/batch.go 77.14% <0.00%> (-2.27%) ⬇️
goleveldb/batch.go 90.00% <0.00%> (-3.11%) ⬇️
memdb/batch.go 90.90% <0.00%> (-2.85%) ⬇️
memdb/db.go 55.88% <0.00%> (-0.84%) ⬇️
metadb/db.go 47.05% <ø> (ø)
rocksdb/batch.go 68.29% <0.00%> (-14.07%) ⬇️
badgerdb/db.go 50.00% <50.00%> (-0.73%) ⬇️
boltdb/db.go 44.08% <50.00%> (-0.48%) ⬇️
... and 10 more
Impacted Files Coverage Δ
badgerdb/batch.go 96.15% <0.00%> (-3.85%) ⬇️
boltdb/batch.go 80.55% <0.00%> (-2.31%) ⬇️
cleveldb/batch.go 77.14% <0.00%> (-2.27%) ⬇️
goleveldb/batch.go 90.00% <0.00%> (-3.11%) ⬇️
memdb/batch.go 90.90% <0.00%> (-2.85%) ⬇️
memdb/db.go 55.88% <0.00%> (-0.84%) ⬇️
metadb/db.go 47.05% <ø> (ø)
rocksdb/batch.go 68.29% <0.00%> (-14.07%) ⬇️
badgerdb/db.go 50.00% <50.00%> (-0.73%) ⬇️
boltdb/db.go 44.08% <50.00%> (-0.48%) ⬇️
... and 10 more

rdb/batch.go Show resolved Hide resolved
rdb/batch.go Show resolved Hide resolved
rdb/batch.go Show resolved Hide resolved
rdb/db.go Outdated Show resolved Hide resolved
rdb/db.go Show resolved Hide resolved
rdb/db.go Outdated Show resolved Hide resolved
Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not critical, but some improvements.

contrib/get_cleveldb.sh Outdated Show resolved Hide resolved
contrib/get_rocksdb.sh Outdated Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
iproudhon and others added 2 commits January 19, 2022 19:28
Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
chore: removed duplicated line, added comments about read / write options
@iproudhon iproudhon requested a review from 0Tech January 20, 2022 04:15
Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iproudhon iproudhon merged commit 61d2bc1 into main Jan 21, 2022
@tnasu tnasu deleted the stonesdb-2 branch April 22, 2022 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants