Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor tests for cosmwasm/wasm/v1/tx.proto other than TestClearAdmin #100

Merged
merged 19 commits into from
Aug 25, 2023

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Aug 24, 2023

Description

Refactor TestInstantiateContract, TestInstantiateContract2, TestMigrateContract, and TestExecuteContract
Spec: https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#cosmwasm/wasm/v1/tx.proto
close #86

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

@Kynea0b Kynea0b self-assigned this Aug 24, 2023
@Kynea0b Kynea0b changed the title Refactor refactor TestInstantiateContract, TestInstantiateContract2, TestMigrateContract, and TestExecuteContract Aug 25, 2023
@Kynea0b Kynea0b marked this pull request as ready for review August 25, 2023 01:16
@da1suk8
Copy link
Member

da1suk8 commented Aug 25, 2023

The instantiateResponse of TestInstantiateContract2 is also not needed and could be removed.

x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
x/wasm/keeper/msg_server_integration_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #100 (c27e2ec) into main (93fed34) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

❗ Current head c27e2ec differs from pull request most recent head e05535b. Consider uploading reports for the commit e05535b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
+ Coverage   63.62%   63.65%   +0.02%     
==========================================
  Files          80       80              
  Lines       10001    10001              
==========================================
+ Hits         6363     6366       +3     
+ Misses       3308     3306       -2     
+ Partials      330      329       -1     

see 1 file with indirect coverage changes

170210
170210 previously approved these changes Aug 25, 2023
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kynea0b
Copy link
Author

Kynea0b commented Aug 25, 2023

Thanks for your comment.

The instantiateResponse of TestInstantiateContract2 is also not needed and could be removed.

I unify to test MsgInstantiateContractResponse.

@Kynea0b Kynea0b changed the title refactor TestInstantiateContract, TestInstantiateContract2, TestMigrateContract, and TestExecuteContract refactor TestInstantiateContract, TestInstantiateContract2, TestMigrateContract, TestExecuteContract, and TestStoreContract Aug 25, 2023
@Kynea0b Kynea0b changed the title refactor TestInstantiateContract, TestInstantiateContract2, TestMigrateContract, TestExecuteContract, and TestStoreContract refactor Tests other than TestClearAdmin Aug 25, 2023
@Kynea0b Kynea0b changed the title refactor Tests other than TestClearAdmin refactor tests other than TestClearAdmin Aug 25, 2023
@Kynea0b Kynea0b changed the title refactor tests other than TestClearAdmin refactor tests for cosmwasm/wasm/v1/tx.proto other than TestClearAdmin Aug 25, 2023
@Kynea0b Kynea0b changed the title refactor tests for cosmwasm/wasm/v1/tx.proto other than TestClearAdmin refactor tests for cosmwasm/wasm/v1/tx.proto other than TestClearAdmin Aug 25, 2023
@Kynea0b Kynea0b changed the title refactor tests for cosmwasm/wasm/v1/tx.proto other than TestClearAdmin refactor tests for cosmwasm/wasm/v1/tx.proto other than TestClearAdmin Aug 25, 2023
@Kynea0b Kynea0b merged commit 9b19afb into Finschia:main Aug 25, 2023
7 checks passed
@Kynea0b Kynea0b deleted the refactor branch August 25, 2023 12:57
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring message_sever integration test
3 participants