fix: fill ContractHistory querier result's Updated field #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 62.02% 61.98% -0.05%
==========================================
Files 80 80
Lines 9971 9966 -5
==========================================
- Hits 6185 6177 -8
- Misses 3450 3452 +2
- Partials 336 337 +1
|
da1suk8
approved these changes
Aug 10, 2023
dudong2
approved these changes
Aug 10, 2023
loloicci
added a commit
that referenced
this pull request
Aug 18, 2023
* Return contract history updates * fix: fill Updated in legacy query ContractHistory * docs: add this PR to CHANGELOG * test: fix a cli test to check Updated --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
5 tasks
loloicci
added a commit
that referenced
this pull request
Aug 18, 2023
…62) (#85) * fix: fill ContractHistory querier result's Updated field (#62) * Return contract history updates * fix: fill Updated in legacy query ContractHistory * docs: add this PR to CHANGELOG * test: fix a cli test to check Updated --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com> * docs: fix CHANGELOG --------- Co-authored-by: Alex Peters <alpe@users.noreply.github.com>
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this PR,
ContractHistoryalways returns its'Updatedfield as nil.This PR cherry-picks CosmWasm@9cbf64d and fixes
ContractHistorylegacy querier to fill the Updated field.How has this been tested?
Unit tests
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not needed)