Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add the check for expPaginationTotal #73

Merged
merged 7 commits into from
Aug 16, 2023

Conversation

Kynea0b
Copy link

@Kynea0b Kynea0b commented Aug 15, 2023

Description

This PR is for checking this field.

https://github.com/Finschia/finschia-sdk/blob/ba75f8e7845a740afdce6e5f1c91f1a97433b7e2/proto/cosmos/base/query/v1beta1/pagination.proto#L54

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

@Kynea0b Kynea0b self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #73 (57862eb) into main (8eca926) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 57862eb differs from pull request most recent head 12ab38f. Consider uploading reports for the commit 12ab38f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   62.32%   62.25%   -0.08%     
==========================================
  Files          80       80              
  Lines        9966     9966              
==========================================
- Hits         6211     6204       -7     
- Misses       3429     3434       +5     
- Partials      326      328       +2     

see 2 files with indirect coverage changes

@Kynea0b Kynea0b marked this pull request as ready for review August 15, 2023 05:36
da1suk8
da1suk8 previously approved these changes Aug 16, 2023
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
@da1suk8 da1suk8 self-requested a review August 16, 2023 05:01
@Kynea0b Kynea0b merged commit bdce468 into Finschia:main Aug 16, 2023
7 checks passed
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants