forked from CosmWasm/wasmd
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add the check for expPaginationTotal
#73
Merged
Kynea0b
merged 7 commits into
Finschia:main
from
Kynea0b:check-field-expPaginationTotal
Aug 16, 2023
Merged
test: add the check for expPaginationTotal
#73
Kynea0b
merged 7 commits into
Finschia:main
from
Kynea0b:check-field-expPaginationTotal
Aug 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 62.32% 62.25% -0.08%
==========================================
Files 80 80
Lines 9966 9966
==========================================
- Hits 6211 6204 -7
- Misses 3429 3434 +5
- Partials 326 328 +2 |
170210
reviewed
Aug 15, 2023
170210
reviewed
Aug 16, 2023
da1suk8
previously approved these changes
Aug 16, 2023
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
da1suk8
approved these changes
Aug 16, 2023
170210
approved these changes
Aug 16, 2023
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for checking this field.
https://github.com/Finschia/finschia-sdk/blob/ba75f8e7845a740afdce6e5f1c91f1a97433b7e2/proto/cosmos/base/query/v1beta1/pagination.proto#L54
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml
(not needed)