Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add event checking to TestInstantiateContract2 #74

Merged
merged 7 commits into from
Aug 18, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Aug 15, 2023

Description

TestInstantiateContract2

https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#msginstantiatecontract2

This PR adds an integration test for TestInstantiateContract2.

This test is based on https://github.com/CosmWasm/wasmd/blob/33df4aeaaa419f6aad07b94d64c0423bee0a2d21/x/wasm/keeper/msg_server_integration_test.go#L899-L976

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@da1suk8 da1suk8 self-assigned this Aug 15, 2023
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #74 (5817116) into main (87f69d6) will increase coverage by 0.19%.
The diff coverage is n/a.

❗ Current head 5817116 differs from pull request most recent head a300e47. Consider uploading reports for the commit a300e47 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
+ Coverage   62.38%   62.57%   +0.19%     
==========================================
  Files          80       80              
  Lines        9966     9966              
==========================================
+ Hits         6217     6236      +19     
+ Misses       3425     3403      -22     
- Partials      324      327       +3     

see 1 file with indirect coverage changes

@da1suk8 da1suk8 marked this pull request as ready for review August 16, 2023 10:28
@da1suk8 da1suk8 requested a review from 170210 August 16, 2023 10:29
Kynea0b
Kynea0b previously approved these changes Aug 17, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
@da1suk8 da1suk8 requested review from 170210 and Kynea0b August 17, 2023 04:09
@da1suk8 da1suk8 requested a review from 170210 August 18, 2023 04:39
@da1suk8 da1suk8 merged commit bb3a88f into Finschia:main Aug 18, 2023
7 checks passed
@da1suk8 da1suk8 deleted the test/TestInstantiateContract2 branch August 18, 2023 06:15
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants