Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add event checking to TestMigrateContract #78

Merged
merged 9 commits into from
Aug 18, 2023

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Aug 16, 2023

Description

TestInstantiateContract

https://github.com/Finschia/wasmd/blob/main/docs/proto/proto-docs.md#msgmigratecontract

This PR adds an integration test for TestMigrateContract.

This test is based on https://github.com/CosmWasm/wasmd/blob/33df4aeaaa419f6aad07b94d64c0423bee0a2d21/x/wasm/keeper/msg_server_integration_test.go#L740-L825

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@da1suk8 da1suk8 changed the title Test/test migrate contract test: add event checking to TestMigrateContract Aug 16, 2023
@da1suk8 da1suk8 self-assigned this Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #78 (9e07e41) into main (bb3a88f) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
+ Coverage   62.54%   62.71%   +0.17%     
==========================================
  Files          80       80              
  Lines        9966     9966              
==========================================
+ Hits         6233     6250      +17     
+ Misses       3405     3385      -20     
- Partials      328      331       +3     

see 1 file with indirect coverage changes

@da1suk8 da1suk8 marked this pull request as ready for review August 16, 2023 11:01
@da1suk8 da1suk8 requested a review from 170210 August 16, 2023 11:01
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
170210
170210 previously approved these changes Aug 17, 2023
Copy link

@170210 170210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@da1suk8
Copy link
Member Author

da1suk8 commented Aug 18, 2023

@170210

I deleted contract_addr and I used instantiate.Address instead of contract_addr.
Thanks.

170210
170210 previously approved these changes Aug 18, 2023
@Kynea0b Kynea0b merged commit 9c983a9 into Finschia:main Aug 18, 2023
12 checks passed
@da1suk8 da1suk8 deleted the test/TestMigrateContract branch August 18, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants