forked from CosmWasm/wasmd
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add an integration test for TestStoreAndInstantiateContract #79
Merged
da1suk8
merged 11 commits into
Finschia:main
from
da1suk8:test/TestStoreAndInstantiateContract
Aug 23, 2023
Merged
test: add an integration test for TestStoreAndInstantiateContract #79
da1suk8
merged 11 commits into
Finschia:main
from
da1suk8:test/TestStoreAndInstantiateContract
Aug 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same as x/wasm/keeper/testdata/reflect.wasm
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 62.95% 63.18% +0.23%
==========================================
Files 80 80
Lines 9965 9965
==========================================
+ Hits 6273 6296 +23
+ Misses 3369 3343 -26
- Partials 323 326 +3 |
da1suk8
force-pushed
the
test/TestStoreAndInstantiateContract
branch
from
August 17, 2023 00:54
cf149a8
to
2b61346
Compare
da1suk8
changed the title
test: add TestStoreAndInstantiateContract
test: add an integration test for TestStoreAndInstantiateContract
Aug 17, 2023
170210
previously approved these changes
Aug 17, 2023
170210
reviewed
Aug 18, 2023
170210
previously approved these changes
Aug 18, 2023
Kynea0b
previously approved these changes
Aug 18, 2023
170210
previously approved these changes
Aug 23, 2023
Kynea0b
reviewed
Aug 23, 2023
Kynea0b
previously approved these changes
Aug 23, 2023
Co-authored-by: kokeshiM0chi <52264064+kokeshiM0chi@users.noreply.github.com>
170210
approved these changes
Aug 23, 2023
Kynea0b
approved these changes
Aug 23, 2023
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TestStoreAndInstantiateContract
This PR adds an integration test for
StoreAndInstantiateContract
.This test is based on https://github.com/CosmWasm/wasmd/blob/33df4aeaaa419f6aad07b94d64c0423bee0a2d21/x/wasm/keeper/msg_server_integration_test.go#L553-L611
StoreAndInstantiate does not compare checksum(
events[0].Attributes[0].Value
) because the checksum is not exposed to the outside world.See:
wasmd/x/wasmplus/keeper/msg_server.go
Line 31 in f800042
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml