fix: fill ContractInfo result's Updated field #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
+ Coverage 62.80% 62.82% +0.02%
==========================================
Files 80 80
Lines 9966 9965 -1
==========================================
+ Hits 6259 6261 +2
+ Misses 3379 3377 -2
+ Partials 328 327 -1
|
170210
requested review from
da1suk8,
dudong2,
loloicci and
Kynea0b
as code owners
loloicci
approved these changes
Aug 21, 2023
da1suk8
approved these changes
Aug 21, 2023
Kynea0b
approved these changes
Aug 22, 2023
170210
added a commit
to 170210/wasmd
that referenced
this pull request
Aug 22, 2023
* fix: fill Updated in queryContractInfo result Signed-off-by: 170210 <j170210@icloud.com> * chore: add this PR to CHANGELOG Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com>
5 tasks
170210
added a commit
that referenced
this pull request
Aug 22, 2023
* fix: fill ContractInfo result's Updated field (#89) * fix: fill Updated in queryContractInfo result Signed-off-by: 170210 <j170210@icloud.com> * chore: add this PR to CHANGELOG Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com> * chore: fix CHANGELOG Signed-off-by: 170210 <j170210@icloud.com> --------- Signed-off-by: 170210 <j170210@icloud.com>
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Without this PR,
ContractInfoalways returns its'Updatedfield as nil.How has this been tested?
Unit tests
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not need)