refactor: refactor TestStoreAndInstantiateContract #98
+56
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kynea0b
requested review from
da1suk8,
dudong2,
loloicci and
170210
as code owners
170210
reviewed
Aug 24, 2023
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
Kynea0b
changed the title
|
LGTM, I will approve when the conflict has been corrected. |
|
@170210 Since there is no particular reason to delete it, it is better to test all fields. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
==========================================
- Coverage 63.69% 63.62% -0.08%
==========================================
Files 80 80
Lines 9994 10001 +7
==========================================
- Hits 6366 6363 -3
- Misses 3299 3308 +9
- Partials 329 330 +1 |
dudong2
previously approved these changes
Aug 25, 2023
da1suk8
previously approved these changes
Aug 25, 2023
170210
reviewed
Aug 25, 2023
|
Sorry, the last two commits are wrong, so I will revert. |
170210
approved these changes
Aug 25, 2023
da1suk8
approved these changes
Aug 25, 2023
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor TestStoreAndInstantiateContract
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not needed)