Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replace line modules with Finschia's #109

Merged
merged 8 commits into from
Apr 18, 2023

Conversation

loloicci
Copy link
Contributor

Description

This PR

  • change depending cosmwasm from line/cosmwasm to Finschia/cosmwasm
  • change module name from line/wasmvm to Finschia/wasmvm

Closes #104

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@loloicci loloicci self-assigned this Apr 17, 2023
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not this PR need to update libwasmvm?

@loloicci
Copy link
Contributor Author

@zemyblue https://github.com/Finschia/wasmvm/pull/109/files#diff-7784ff7f71b03e2ac76718bfd14eee8e503adcbf1cd1c134d60f88b405f36aaf isn't it enough? Or, need re-build libwasmvm?

@zemyblue
Copy link
Member

@zemyblue https://github.com/Finschia/wasmvm/pull/109/files#diff-7784ff7f71b03e2ac76718bfd14eee8e503adcbf1cd1c134d60f88b405f36aaf isn't it enough? Or, need re-build libwasmvm?

In this PR, there are no compiled libwasmvm files, so I ask to you. Is it no need?

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change README.md file.

  • line/wasmvm -> Finschia/wasmvm
  • line/lbm-sdk -> Finschia/finschia-sdk

And Makefile also.

  • line/wasmvm-builder -> finschia/wasmvm-builder

And all changelog's links

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check also updating copyright holder in NOTICE and LICENSE files.

@loloicci loloicci force-pushed the depending-finschia branch from e60662b to 0c1b997 Compare April 18, 2023 06:53
Copy link

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First line of CONTRIBUTINGL.md should be Finschia/wasmvm.

@jaeseung-bae
Copy link

In CODE_OF.CONDUCT.md file's line 63
Please change [dl_oss_dev@linecorp.com](mailto:dl_oss_dev@linecorp.com) to [dev@finschia.org](mailto:dev@finschia.org)

@da1suk8
Copy link
Member

da1suk8 commented Apr 18, 2023

finschia-sdk and lbm-sdk are mixed.
This is all to match finschia-sdk, right?

There is in callbacks.go, mocks.go, ibc.go and msg.go.

@loloicci loloicci merged commit ce70a38 into Finschia:main Apr 18, 2023
@loloicci loloicci deleted the depending-finschia branch April 18, 2023 09:32
@loloicci loloicci mentioned this pull request Apr 20, 2023
loloicci added a commit that referenced this pull request Jun 14, 2023
* fix: wrong tag reference (v1.1.1-0.11.2) (#95)

* chore: update latest `line/cosmwasm` commit (merged Finschia/cosmwasm#256 PR)

Signed-off-by: zemyblue <zemyblue@gmail.com>

* add library

* add changelog

* ci: add ci test about compiled internal libraries.

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>

* feat: add codeowners file (#100)

* fix: fix a test for rustc 1.68 or later (#108)

* build: replace line modules with Finschia's (#109)

* build: change depending cosmwasm and repository info to finschia

* build: replace module name line/wasmvm with Finschia/wasmvm

* docs: replace "line" with "Finschia" in docs and scripts related docs

* docs: change copylight

* build: rename docker containers from line/* to finschia/*

* docs: replace lbm-sdk with finschia-sdk

* docs: replace mail address and repository name

* docs: replace lbm-sdk with finschia-sdk in comments

* chore: update cargo author information. (#112)

* chore: update cargo author information.

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: update changelog

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: zemyblue <zemyblue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update depending cosmwasm's URL
5 participants