-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: replace line modules with Finschia's #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does not this PR need to update libwasmvm
?
@zemyblue https://github.com/Finschia/wasmvm/pull/109/files#diff-7784ff7f71b03e2ac76718bfd14eee8e503adcbf1cd1c134d60f88b405f36aaf isn't it enough? Or, need re-build libwasmvm? |
In this PR, there are no compiled libwasmvm files, so I ask to you. Is it no need? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also change README.md file.
- line/wasmvm -> Finschia/wasmvm
- line/lbm-sdk -> Finschia/finschia-sdk
And Makefile also.
- line/wasmvm-builder -> finschia/wasmvm-builder
And all changelog's links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check also updating copyright holder in NOTICE and LICENSE files.
e60662b
to
0c1b997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First line of CONTRIBUTINGL.md should be Finschia/wasmvm
.
In CODE_OF.CONDUCT.md file's line 63 |
finschia-sdk and lbm-sdk are mixed. There is in callbacks.go, mocks.go, ibc.go and msg.go. |
* fix: wrong tag reference (v1.1.1-0.11.2) (#95) * chore: update latest `line/cosmwasm` commit (merged Finschia/cosmwasm#256 PR) Signed-off-by: zemyblue <zemyblue@gmail.com> * add library * add changelog * ci: add ci test about compiled internal libraries. Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> * feat: add codeowners file (#100) * fix: fix a test for rustc 1.68 or later (#108) * build: replace line modules with Finschia's (#109) * build: change depending cosmwasm and repository info to finschia * build: replace module name line/wasmvm with Finschia/wasmvm * docs: replace "line" with "Finschia" in docs and scripts related docs * docs: change copylight * build: rename docker containers from line/* to finschia/* * docs: replace lbm-sdk with finschia-sdk * docs: replace mail address and repository name * docs: replace lbm-sdk with finschia-sdk in comments * chore: update cargo author information. (#112) * chore: update cargo author information. Signed-off-by: zemyblue <zemyblue@gmail.com> * chore: update changelog Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> --------- Signed-off-by: zemyblue <zemyblue@gmail.com> Co-authored-by: zemyblue <zemyblue@gmail.com>
Description
This PR
Closes #104
Types of changes
Checklist