Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add an automatic build shared library ci #119

Merged
merged 5 commits into from
Sep 11, 2023
Merged

chore: add an automatic build shared library ci #119

merged 5 commits into from
Sep 11, 2023

Conversation

170210
Copy link
Contributor

@170210 170210 commented Aug 4, 2023 •
edited
Loading

Description

This PR has following changes.

  • add a CI which automatic build the shared libraries.

Closes #116

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@170210 170210 self-assigned this Aug 4, 2023
@170210 170210 added the enhancement New feature or request label Aug 4, 2023
@170210 170210 requested a review from zemyblue August 4, 2023 06:30
@170210 170210 marked this pull request as draft August 4, 2023 06:30
@170210 170210 marked this pull request as ready for review August 7, 2023 04:38
@zemyblue zemyblue mentioned this pull request Aug 23, 2023
Merged
8 tasks
@170210
chore: add an automatic build shared library ci
622f85e 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 force-pushed the feature/issue_116 branch from 02ff110 to 622f85e Compare August 31, 2023 10:22
@170210
chore: add checksum file
558d101 
Signed-off-by: 170210 <j170210@icloud.com>
zemyblue
zemyblue reviewed Aug 31, 2023
View reviewed changes
.github/workflows/deploy_to_git.yml Outdated Show resolved Hide resolved
internal/api/checksums.txt Outdated Show resolved Hide resolved
@170210
fixup: fix for comment
f8bdf99 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
fixup: use git diff instead of checksum
c6040a1 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested review from tnasu and zemyblue September 4, 2023 04:23
loloicci
loloicci reviewed Sep 5, 2023
View reviewed changes
.github/workflows/deploy_to_git.yml Outdated Show resolved Hide resolved
.github/workflows/deploy_to_git.yml Outdated Show resolved Hide resolved
@170210
fixup: fix for comment
47a5996 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested a review from loloicci September 5, 2023 04:49
@170210 170210 merged commit bf6d128 into Finschia:main Sep 11, 2023
@170210 170210 deleted the feature/issue_116 branch September 11, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloicci loloicci loloicci approved these changes

@zemyblue zemyblue zemyblue approved these changes

@da1suk8 da1suk8 Awaiting requested review from da1suk8 da1suk8 is a code owner

@dudong2 dudong2 Awaiting requested review from dudong2

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

@tnasu tnasu Awaiting requested review from tnasu

Assignees

@170210 170210

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How about adding a ci which automatic build shared library?
3 participants
@170210 @zemyblue @loloicci