Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add .so / .dylib file and modify Makefile #85

Merged
merged 2 commits into from
Jan 13, 2023
Merged

fix: add .so / .dylib file and modify Makefile #85

merged 2 commits into from
Jan 13, 2023
+4 −2

Conversation

shiki-tak
Copy link
Contributor

Description

Added .so / .dylib file that was missing from PR #84.

Types of changes

  • Bug fix (changes which fixes an issue)
  • New feature (changes which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • ETC (build, ci, docs, perf, refactor, style, test)

Checklist

@shiki-tak shiki-tak self-assigned this Jan 13, 2023
zemyblue
zemyblue approved these changes Jan 13, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.a library is not need?

@shiki-tak
Copy link
Contributor Author

.a library is not need?

Yes, It has been gitignore before.

https://github.com/line/wasmvm/blob/v1.0.0-0.10.0/.gitignore#L9

@shiki-tak shiki-tak merged commit 89650a7 into Finschia:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loloicci loloicci loloicci approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@shiki-tak shiki-tak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shiki-tak @zemyblue @loloicci