Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development guide #47

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Add development guide #47

merged 1 commit into from
Oct 22, 2020

Conversation

jhuleatt
Copy link
Collaborator

Add a guide with more information about how to get set up to develop the action. Also add notes on how to publish new versions.

@jhuleatt jhuleatt requested a review from jamesdaniels October 21, 2020 20:02
@google-cla google-cla bot added the cla: yes Contributor has signed CLA label Oct 21, 2020
expatiating added a commit to expatiating/action-hosting-deploy that referenced this pull request Oct 22, 2020
@jhuleatt jhuleatt merged commit 58c4f50 into main Oct 22, 2020
jhuleatt added a commit that referenced this pull request Oct 23, 2020
* Add target option

* Fix format

* Update src/deploy.ts

DRY `--only hosting` once

Co-authored-by: Jeff <jhuleatt@google.com>

* Update src/deploy.ts

Co-authored-by: Jeff <jhuleatt@google.com>

* Update action.yml

Not really pertinent to my change, but reads clearer, so thank you 🤓

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

* Better description

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

* Make target optional in productionDeployConfig

* Commit prettier suggestions

* Add bin contents per #47 workflow

Co-authored-by: Jeff <jhuleatt@google.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 01c9c52):

https://action-hosting-deploy-demo--pr47-update-contributing-tybmg32d.web.app

(expires Thu, 12 Nov 2020 21:27:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

pomle pushed a commit to pomle/action-hosting-deploy that referenced this pull request Nov 8, 2020
pomle pushed a commit to pomle/action-hosting-deploy that referenced this pull request Nov 8, 2020
* Add target option

* Fix format

* Update src/deploy.ts

DRY `--only hosting` once

Co-authored-by: Jeff <jhuleatt@google.com>

* Update src/deploy.ts

Co-authored-by: Jeff <jhuleatt@google.com>

* Update action.yml

Not really pertinent to my change, but reads clearer, so thank you 🤓

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

* Better description

Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>

* Make target optional in productionDeployConfig

* Commit prettier suggestions

* Add bin contents per FirebaseExtended#47 workflow

Co-authored-by: Jeff <jhuleatt@google.com>
Co-authored-by: rachelsaunders <52258509+rachelsaunders@users.noreply.github.com>
@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Nov 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants