Improve stability of the repo #296

kotl · 2017-11-11T02:37:27Z

This update contains:

using shared_ptr properly instead of unique_ptr
use latest JSON library and deleting old one (please download it from head or use stable release)
https://github.com/bblanchon/ArduinoJson
do not crash when streaming deletions as well as allowing to detect deletion

pull updates

… and use latest one.

googlebot · 2017-11-11T02:37:30Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

proppy · 2017-11-11T03:03:47Z

Can you add the new version of ArduinoJson to the third-party directory?

…y shipped with repo.

kotl · 2017-11-12T02:45:31Z

Finally fixed both CI builds.

proppy · 2017-11-13T01:48:49Z

.travis.yml

@@ -9,7 +9,6 @@ addons:
    - g++-4.8
 env:
 - ARDUINO_VERSION=1.6.9 ARDUINO_ESP8266_VERSION=2.3.0 LIB_NEOPIXEL_VERSION=v1.0.5 LIB_GFX_VERSION=v1.1.5 LIB_SSD1306_VERSION=1.1.0 LIB_JSON_VERSION=v5.11.2 ARDUINO_ROOT=${HOME}/arduino-${ARDUINO_VERSION} ARDUINO_ESP8266_ROOT=${ARDUINO_ROOT}/hardware/esp8266com/esp8266 ARDUINO_HOME=${HOME}/Arduino
- ARDUINO_VERSION=nightly ARDUINO_ESP8266_VERSION=master LIB_NEOPIXEL_VERSION=master LIB_GFX_VERSION=master LIB_SSD1306_VERSION=master LIB_JSON_VERSION=master ARDUINO_ROOT=${HOME}/arduino-${ARDUINO_VERSION} ARDUINO_ESP8266_ROOT=${ARDUINO_ROOT}/hardware/esp8266com/esp8266 ARDUINO_HOME=${HOME}/Arduino


are you removing nightly on purpose?

proppy · 2017-11-13T01:51:03Z

.travis.yml

- ${ARDUINO_ROOT}/arduino-builder -verbose  -hardware ${ARDUINO_ROOT}/hardware/ -tools ${ARDUINO_ESP8266_ROOT}/tools/ -tools ${ARDUINO_ROOT}/tools-builder/ -fqbn esp8266com:esp8266:nodemcuv2 -libraries ${ARDUINO_HOME}/libraries/ -prefs build.flash_ld=${ARDUINO_ESP8266_ROOT}/tools/sdk/ld/eagle.flash.4m.ld -prefs build.flash_freq=40 -prefs build.flash_size=4M examples/FirebaseNeoPixel_ESP8266/FirebaseNeoPixel_ESP8266.ino
- ${ARDUINO_ROOT}/arduino-builder -verbose  -hardware ${ARDUINO_ROOT}/hardware/ -tools ${ARDUINO_ESP8266_ROOT}/tools/ -tools ${ARDUINO_ROOT}/tools-builder/ -fqbn esp8266com:esp8266:nodemcuv2 -libraries ${ARDUINO_HOME}/libraries/ -prefs build.flash_ld=${ARDUINO_ESP8266_ROOT}/tools/sdk/ld/eagle.flash.4m.ld -prefs build.flash_freq=40 -prefs build.flash_size=4M examples/FirebaseStream_ESP8266/FirebaseStream_ESP8266.ino
- ${ARDUINO_ROOT}/arduino-builder -verbose  -hardware ${ARDUINO_ROOT}/hardware/ -tools ${ARDUINO_ESP8266_ROOT}/tools/ -tools ${ARDUINO_ROOT}/tools-builder/ -fqbn esp8266com:esp8266:nodemcuv2 -libraries ${ARDUINO_HOME}/libraries/ -prefs build.flash_ld=${ARDUINO_ESP8266_ROOT}/tools/sdk/ld/eagle.flash.4m.ld -prefs build.flash_freq=40 -prefs build.flash_size=4M examples/FirebaseRoom_ESP8266/FirebaseRoom_ESP8266.ino
+- ${ARDUINO_ROOT}/arduino-builder -verbose  -hardware ${ARDUINO_ROOT}/hardware/ -tools ${ARDUINO_ESP8266_ROOT}/tools/ -tools ${ARDUINO_ROOT}/tools-builder/ -fqbn esp8266com:esp8266:nodemcuv2 -libraries ${ARDUINO_HOME}/libraries/ -prefs build.flash_ld=${ARDUINO_ESP8266_ROOT}/tools/sdk/ld/eagle.flash.4m.ld -prefs build.flash_freq=40 -prefs build.flash_size=4M -prefs build.f_cpu=80000000 examples/FirebaseDemo_ESP8266/FirebaseDemo_ESP8266.ino


I'm curious why this is not already added by the board package:
https://github.com/esp8266/Arduino/blob/master/boards.txt#L1353

It did not work without it, I had to create my own travis docker container to figure out why the heck it was failing.

proppy · 2017-11-13T01:51:57Z

README.rst

-types.
+friendly way.
+
+ArduinoJson is no longer part of this library and you will have to install latest version


Maybe we should add a new # DEPENDENCIES sections in the README?

proppy · 2017-11-13T01:54:26Z

src/Firebase.h

  FirebaseError error_;
  std::string response_;
-  DynamicJsonBuffer buffer_;
+  std::shared_ptr<StaticJsonBuffer<FIREBASE_JSONBUFFER_SIZE>> buffer_;


Maybe this could simply be statically allocated as
StaticJsonBuffer<FIREBASE_JSONBUFFER_SIZE> buffer_ without shared_ptr?

I don't remember the details, but I am pretty sure latest version of JSONArduino is very strict on memory allocations so passing this buffer around as-is results in compilation errors.

…g stream has closed.

proppy · 2017-11-20T02:33:08Z

ping?

hunsalz · 2018-01-17T13:44:47Z

Any update appreciated. - It would be great to dissolve the current dependency to the contributed JSON library and use Arduino JSON form head or a stable version.

kotl · 2018-01-22T04:56:05Z

I am really sorry, I did not follow up on these changes. This change was intended to be complemented by other changes in the main esp8266 repo for handling https contexts to make a rock solid firmware that never crashes and also allowing firebase-arduino for 2 simultaneous connections to stream and write at the same time. And the moment I had it working well, esp8266 repo got changed so much, that fixes I already tested and debugged for many days, stopped working, so regrettably I decided to abandon this route.

However, I believe there is still a benefit to get this change in for firebase-arduino repo, so if @proppy let's me try again, I would be happy to submit this.

kotl · 2018-01-25T03:48:30Z

@proppy , @vikrum can you take a look again at this?

hunsalz · 2018-01-29T19:09:39Z

@kotl can you try again with a signed CLA?

googlebot · 2018-01-29T20:23:30Z

CLAs look good, thanks!

kotl · 2018-01-29T20:24:24Z

Done!

proppy · 2018-01-31T07:22:19Z

Thanks for working on this!

proppy · 2018-01-31T07:47:40Z

Tested successfully with the following sketch


void setup() {
  Serial.begin(9600);
  
  // connect to wifi.
  WiFi.begin(WIFI_SSID, WIFI_PASSWORD);
  Serial.print("connecting");
  while (WiFi.status() != WL_CONNECTED) {
    Serial.print(".");
    delay(500);
  }
  Serial.println();
  Serial.print("connected: ");
  Serial.println(WiFi.localIP());
  
  Firebase.begin(FIREBASE_HOST, FIREBASE_SECRET);
}


void loop() {
  Firebase.stream("/");

  if (Firebase.failed()) {
    Serial.println("streaming error");
    Serial.println(Firebase.error());
    return;
  }
  
  if (Firebase.available()) {
     FirebaseObject event = Firebase.readEvent();
     String eventType = event.getString("type");
     eventType.toLowerCase();
     Serial.print("event: ");
     Serial.println(eventType);
     if (eventType == "put") {
       String path = event.getString("path");
       int data = event.getInt("data");
       Serial.print("data: ");
       Serial.print(path);
       Serial.print("=");
       Serial.println(data);
     }
  }
 }

lenguyenvu007 · 2018-03-18T00:12:11Z

Thank you for your update, Stream works fine. But if I test changing value by Update, not Set.
After then eventType = "patch", Stream does not return any data. Any suggestion about this case ?

proppy · 2018-03-19T02:25:26Z

@lenguyenvu007 can you file a separate issue about this? Thanks!

kotl and others added 3 commits September 21, 2017 22:20

Merge pull request #1 from firebase/master

08bed6b

pull updates

Add ability to detect null string (happens when nodes gets deleted)

d7aebba

Crazy update to use shared_ptr and get rid of old ArduinoJson library…

d2138bf

… and use latest one.

kotl requested a review from proppy November 11, 2017 02:37

kotl added 8 commits November 10, 2017 22:59

Add changes/info needed to pass CI build.

ae903b0

Forgot to add symbolic link.

b6712d2

And finally removing symbolic link created for json library previousl…

e175110

…y shipped with repo.

Fix contrib directory to use external ArduinoJson library.

6b768f9

More fixes for contrib test to use external JSON library.

651a5b9

fix issues with travis build

7c89e0d

Add back getPtr functions.

1f8746d

Fixing modem tests

02cfb98

add build.f_cpu preference

57df59e

proppy reviewed Nov 13, 2017

View reviewed changes

kotl added 2 commits November 12, 2017 22:16

Avoid crashes when .available() is called by detecting that underlyin…

90ce6f1

…g stream has closed.

Merge branch 'master' of https://github.com/kotl/firebase-arduino

b8c152f

kotl added 3 commits January 22, 2018 00:04

Add back nightly build environment

09cd329

Added section about ArduinoJson dependency

bdfe2bc

Merge branch 'master' into master

4276c99

Remove trailing space from the comment

ed75682

proppy approved these changes Jan 31, 2018

View reviewed changes

proppy merged commit 96eab42 into FirebaseExtended:master Jan 31, 2018

This was referenced Jan 31, 2018

Read Firebase only when there is an update in it OR Get push notifications in NodeMCU #308

Closed

Report error when streaming loses connection. #179 #301

Open

kotl mentioned this pull request Feb 20, 2018

Including FirebaseArduino and ArduinoJson causes redefinition errors #246

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve stability of the repo #296

Improve stability of the repo #296

kotl commented Nov 11, 2017

googlebot commented Nov 11, 2017

proppy commented Nov 11, 2017

kotl commented Nov 12, 2017 •

edited

Loading

proppy Nov 13, 2017

proppy Nov 13, 2017

kotl Jan 22, 2018

proppy Nov 13, 2017

kotl Jan 22, 2018

proppy Nov 13, 2017

kotl Jan 22, 2018

proppy commented Nov 20, 2017

hunsalz commented Jan 17, 2018

kotl commented Jan 22, 2018

kotl commented Jan 25, 2018

hunsalz commented Jan 29, 2018

googlebot commented Jan 29, 2018

kotl commented Jan 29, 2018

proppy commented Jan 31, 2018

proppy commented Jan 31, 2018 •

edited

Loading

lenguyenvu007 commented Mar 18, 2018 •

edited

Loading

proppy commented Mar 19, 2018 •

edited

Loading

Improve stability of the repo #296

Improve stability of the repo #296

Conversation

kotl commented Nov 11, 2017

googlebot commented Nov 11, 2017

proppy commented Nov 11, 2017

kotl commented Nov 12, 2017 • edited Loading

proppy Nov 13, 2017

Choose a reason for hiding this comment

proppy Nov 13, 2017

Choose a reason for hiding this comment

kotl Jan 22, 2018

Choose a reason for hiding this comment

proppy Nov 13, 2017

Choose a reason for hiding this comment

kotl Jan 22, 2018

Choose a reason for hiding this comment

proppy Nov 13, 2017

Choose a reason for hiding this comment

kotl Jan 22, 2018

Choose a reason for hiding this comment

proppy commented Nov 20, 2017

hunsalz commented Jan 17, 2018

kotl commented Jan 22, 2018

kotl commented Jan 25, 2018

hunsalz commented Jan 29, 2018

googlebot commented Jan 29, 2018

kotl commented Jan 29, 2018

proppy commented Jan 31, 2018

proppy commented Jan 31, 2018 • edited Loading

lenguyenvu007 commented Mar 18, 2018 • edited Loading

proppy commented Mar 19, 2018 • edited Loading

kotl commented Nov 12, 2017 •

edited

Loading

proppy commented Jan 31, 2018 •

edited

Loading

lenguyenvu007 commented Mar 18, 2018 •

edited

Loading

proppy commented Mar 19, 2018 •

edited

Loading