Implement modem #66

ed7coyne · 2016-03-11T19:41:11Z

This is still a work in progress, definitely needs some cleaning at the least but it is working.

To do this I needed to be able to mock a firebase object. Per our recent discussions this may become much easier with the refactorings we were talking about but this impl will work for now.
Also needed to break out an http client object to keep all the esp8266 from compiling to build a Firebase.
I also needed to be able to build and run locally outside of the arduino framework, as such I have added some dummies and a link to the arduino-mock repository to make this possible.

This reverts commit b975f3b. found out googlemock and googletest are now merged, only need one.

…into modem-impl

…ty and testability.

proppy · 2016-03-11T19:50:01Z

Firebase.cpp

-#define HTTP_CODE_TEMPORARY_REDIRECT 307
-#define USE_ESP_ARDUINO_CORE_2_0_0
-#endif
+using std::unique_ptr;


I wonder if we could assume unique_ptr is there in all arduino c++ toolchains (this would be our first dep on the stl).

This is true, if it isn't we can drop these and fall back to comments saying "the client owns the object and is responsible for freeing" I would prefer to keep it explicit if we can though.

ed7coyne · 2016-03-25T21:02:57Z

The FirebaseSerialHost example is working and I have tested it with the huzzah module. We are still missing the advanced versions of all commands.

I wouldn't mind checking in the simple version though and making a smaller PR for the advanced versions. This one is getting a little large.

ed7coyne · 2016-03-25T21:11:12Z

utility

@@ -0,0 +1 @@
+modem


This is an odd artifact of the arduino IDE. It is a symlink because the IDE will only compile .cpp files that are either in the root of a library or in a folder called "utility". Supposedly git handles symlinks correctly and will create it properly on checkout.

In the long run I am not sure what we want to do. The modem is logically completely separate from the Firebase library so I don't really want to dump them both in a flat folder.

What do you think of separating them into different arduino libraries? Maybe even different github repos?

proppy · 2016-04-08T21:52:39Z

examples/FirebaseSerialHost_ESP8266/FirebaseSerialHost_ESP8266.ino

+//
+
+
+// FirebasePush_ESP8266 is a sample that will start our serial transciever


s/Push/SerialHost/

googlebot · 2016-04-15T18:24:18Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

# The first commit's message is: Update FirebaseStream_ESP8266.ino # This is the 2nd commit message: Fix parsing of returned json object. The json object now has multiple values in data{}. Changing the code to pull the "last" value.

…sing json.

# The first commit's message is: Modem design image # This is the 2nd commit message: Updated diagram # This is the 3rd commit message: Update design.md

Add tests Added gmock/gtest submodules Revert "Added gmock/gtest submodules" This reverts commit b975f3b. found out googlemock and googletest are now merged, only need one. Added googletest submodule Added *Ptr methods to firebase, get test mostly compiling Broke FirebaseHttpClient out from Firebase to allow greater portability and testability. re check in commands and add input stream Working local command test Added base test for set Added base test for set (actually this time) Cleanup set test and add error test Clean up get test and added failure handling Added remove command and test Added push command and test Minor cleanup to set test Added begin command and test Fixed all tests operating on the assumption that readLine() included the \r\n

Getting serial example together Cleaning up Changes to make both arduino and tests compile All existing examples work now. changes to get SerialHost building Fixed up Stream example Fixed up Stream example Fixes to get FirebaseSerialHost.ino working! Switch to huzzah module. All examples are working Add instructions to example and test files. unit tests are all working with new changes Cleanup comments remove arduino-mock Revert "remove arduino-mock" This reverts commit e7aa75f. remove old arduino-mock Add modified submodule Added stream command using simple syntax. Fixes from testing with serial modem

…ttps://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification

Modem design image modified diagram renamed diagram Create design.md Update design.md Updated diagram Update design.md switched diagram back to png Update design.md Update design.md Untested initial command with tests Added gmock/gtest submodules Revert "Added gmock/gtest submodules" This reverts commit b975f3b. found out googlemock and googletest are now merged, only need one. Added googletest submodule import example make file Added *Ptr methods to firebase, get test mostly compiling Broke FirebaseHttpClient out from Firebase to allow greater portability and testability. re check in commands and add input stream Working local command test Added base test for set Added base test for set (actually this time) Cleanup set test and add error test Clean up get test and added failure handling Added remove command and test Added push command and test Minor cleanup to set test Added begin command and test Fixed all tests operating on the assumption that readLine() included the \r\n Add base for SerialTransciever. Getting serial example together Cleaning up Changes to make both arduino and tests compile All existing examples work now. changes to get SerialHost building Fixed up Stream example Fixes to get FirebaseSerialHost.ino working! Switch to huzzah module. All examples are working unit tests are all working with new changes Added stream command using simple syntax. Fixes from testing with serial modem Reorganized the library to comply with arduino 1.5+ library standards https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification Fixed some issues from PR review Modem design image modified diagram renamed diagram Create design.md Update design.md Updated diagram Update design.md switched diagram back to png Update design.md Update design.md Untested initial command with tests Added gmock/gtest submodules Revert "Added gmock/gtest submodules" This reverts commit b975f3b. found out googlemock and googletest are now merged, only need one. Added googletest submodule import example make file Added *Ptr methods to firebase, get test mostly compiling Broke FirebaseHttpClient out from Firebase to allow greater portability and testability. re check in commands and add input stream Working local command test Added base test for set Added base test for set (actually this time) Cleanup set test and add error test Clean up get test and added failure handling Added remove command and test Added push command and test Minor cleanup to set test Added begin command and test Fixed all tests operating on the assumption that readLine() included the \r\n Add base for SerialTransciever. Getting serial example together Cleaning up Changes to make both arduino and tests compile All existing examples work now. changes to get SerialHost building Fixed up Stream example Fixed up Stream example Fixes to get FirebaseSerialHost.ino working! Switch to huzzah module. All examples are working unit tests are all working with new changes Add modified submodule Added stream command using simple syntax. Fixes from testing with serial modem Reorganized the library to comply with arduino 1.5+ library standards https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification Fixed some issues from PR review re check in commands and add input stream Working local command test Update design.md Update design.md Added base test for set Added base test for set (actually this time) Cleanup set test and add error test Added remove command and test Added push command and test Minor cleanup to set test Added begin command and test Fixed all tests operating on the assumption that readLine() included the \r\n Add base for SerialTransciever. Getting serial example together Cleaning up Changes to make both arduino and tests compile All existing examples work now. changes to get SerialHost building Fixed up Stream example Fixed up Stream example Fixes to get FirebaseSerialHost.ino working! Switch to huzzah module. All examples are working unit tests are all working with new changes Add modified submodule Added stream command using simple syntax. Fixes from testing with serial modem Reorganized the library to comply with arduino 1.5+ library standards https://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification Fixed some issues from PR review

googlebot · 2016-04-15T21:36:59Z

CLAs look good, thanks!

ed7coyne · 2016-04-15T22:40:05Z

This PR is being abandoned, it is in a hopeless tailspin of rebasing that I cannot pull it out of. See #83 and #84

ed7coyne added 16 commits February 10, 2016 13:47

Modem design image

75ab6e5

modified diagram

478ff04

renamed diagram

20e256d

Create design.md

d9a2915

Update design.md

545ce38

Updated diagram

1760354

Update design.md

71803c7

switched diagram back to png

c99734b

Untested initial command with tests

a427d7e

Added gmock/gtest submodules

b975f3b

Revert "Added gmock/gtest submodules"

9e45a49

This reverts commit b975f3b. found out googlemock and googletest are now merged, only need one.

Added googletest submodule

292885c

import example make file

9901db5

Merge branch 'master' of https://github.com/ed7coyne/firebase-arduino …

f786598

…into modem-impl

Added *Ptr methods to firebase, get test mostly compiling

6de7f81

Broke FirebaseHttpClient out from Firebase to allow greater portabili…

2723c05

…ty and testability.

proppy reviewed Mar 11, 2016
View reviewed changes

ed7coyne reviewed Mar 25, 2016
View reviewed changes

proppy mentioned this pull request Apr 2, 2016

Firebase serial #71

Open

4 tasks

proppy reviewed Apr 8, 2016
View reviewed changes

# This is a combination of 2 commits.

1ef1d06

# The first commit's message is: Update FirebaseStream_ESP8266.ino # This is the 2nd commit message: Fix parsing of returned json object. The json object now has multiple values in data{}. Changing the code to pull the "last" value.

ed7coyne added 11 commits April 15, 2016 13:46

Fix parsing of returned json object.

bc4a518

Update serial_protocol.md

c03e474

switched variable marker from $ to %%

f07c84a

upgrade library to 1.5 style, import arduino-json-5.1.1 and start par…

54cd2a3

…sing json.

# This is a combination of 3 commits.

2c6cab1

# The first commit's message is: Modem design image # This is the 2nd commit message: Updated diagram # This is the 3rd commit message: Update design.md

Modem design image

2eaf813

Reorganized the library to comply with arduino 1.5+ library standards h…

ca715c8

…ttps://github.com/arduino/Arduino/wiki/Arduino-IDE-1.5:-Library-specification

post rebase cleanup, fix issues with ArduinoJson library

9e52f85

ed7coyne force-pushed the modem-impl branch from 8751308 to 9e52f85 Compare April 15, 2016 21:36

This was referenced Apr 15, 2016

Implement modem (attempt 2) #83

Merged

Add modem example (serialhost) #84

Merged

ed7coyne closed this Apr 15, 2016

ed7coyne deleted the modem-impl branch June 17, 2016 16:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement modem #66

Implement modem #66

ed7coyne commented Mar 11, 2016

proppy Mar 11, 2016

ed7coyne Mar 11, 2016

ed7coyne commented Mar 25, 2016

ed7coyne Mar 25, 2016

proppy Apr 8, 2016

ed7coyne Apr 15, 2016

googlebot commented Apr 15, 2016

googlebot commented Apr 15, 2016

ed7coyne commented Apr 15, 2016

		//


		// FirebasePush_ESP8266 is a sample that will start our serial transciever

Implement modem #66

Implement modem #66

Conversation

ed7coyne commented Mar 11, 2016

proppy Mar 11, 2016

Choose a reason for hiding this comment

ed7coyne Mar 11, 2016

Choose a reason for hiding this comment

ed7coyne commented Mar 25, 2016

ed7coyne Mar 25, 2016

Choose a reason for hiding this comment

proppy Apr 8, 2016

Choose a reason for hiding this comment

ed7coyne Apr 15, 2016

Choose a reason for hiding this comment

googlebot commented Apr 15, 2016

googlebot commented Apr 15, 2016

ed7coyne commented Apr 15, 2016