Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If fakeroot available use it for creating linux install image #17

Conversation

artyom-smirnov
Copy link
Contributor

These changes allow to execute 'make dist' without need of root. 'make install' of course still need root.

This piece of code is same in 2.5/3.0 so it can be used there to.

@AlexPeshkoff
Copy link
Member

Artyom, your usage of fakeroot is not completely correct - all process of package build should happen under same fakeroot, not only makeInstallImage. Currently all root-specific changes, made under fakeroot, get lost before .tgz file is created.

But due to the fact that most of required to build as non-root changes were already done you've succeeded to get installable binary (see CORE-5180). I've missed some changes cause did them in a hurry of 3.0 release which is definitely not good excuse for me.

Currently process of non-root build is tested up to package install. No need in fakeroot for head and 3.0, but if you prepare pull request for 2.5 I'll be glad to merge it. Changes should be made (fakeroot invoked) in builds/posix/Makefile.in.firebird - targets "package packages dist" should be made under fakeroot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants