fix gcc build with -std=c++11 on i386 #58
Conversation
After commit 2f3dc8b ("Added -std=c++11 flag to Linux builds."), i386 (32-bit) linux builds started to fail with "#error Define FB_CPU for your platform". This is because gcc doesn't define "i386" macro with -std=c++11, only "__i386__". While current gcc seems to define both macros without -std=c++11, let's play it safe and check for both.
|
Wouldn't it much simple to do instead: ? |
|
For some other HW we have own define (like -DARM, -DAMD64). May be it will be better going this way for x86 too - instead of guessing what else define will be changed by compiler? |
|
We already define "I386" in src/common/common.h anyway so doing this outside of the source (like we do for AMD64) and checking it everywhere would make sense. |
|
Using external macros will tie us to the death with autoconf for recognizing platform/HW. Autoconf was good 15 years ago, but now GCC has wider set of macros for this. According to standard, these macros must have two underscores in the begin and end. Macros without them are deprecated. If we are changing sources to use new standard, we must use new macros. |
|
I would go with a more readable solution But we all know that I386 is x86_32 and AMD64 is x86_64 so i guess this can be merged |
|
Obsoleted by commit 4107794 |
After commit 2f3dc8b ("Added -std=c++11 flag to Linux builds."),
i386 (32-bit) linux builds started to fail with "#error Define FB_CPU
for your platform". This is because gcc doesn't define "i386" macro with
-std=c++11, only "i386". While current gcc seems to define both
macros without -std=c++11, let's play it safe and check for both.