Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sw_64 support #7824

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add sw_64 support #7824

wants to merge 1 commit into from

Conversation

haomi123
Copy link

@haomi123 haomi123 commented Nov 3, 2023

Add sw_64 support

@AlexPeshkoff AlexPeshkoff self-assigned this Nov 3, 2023
@haomi123 haomi123 closed this Nov 7, 2023
@haomi123 haomi123 reopened this Nov 7, 2023
@AlexPeshkoff
Copy link
Member

Did you try to run tests in extern/libcds? That's HW-dependent library, and I want to make sure does it work correctly on sw-64. Malfunction of it may cause unstable FB operation.

@mariuz
Copy link
Member

mariuz commented Nov 8, 2023

@haomi123 here is example for LoongArch patch for libcds in the firebird tree

fcc471e#diff-31135add04bb8d8584529be04bae88c6a088d3a90c73a6c8c7716bd8bec815db

also upstream pull request
khizmax/libcds#183

ps : @AlexPeshkoff upstream project seems to be unmaintained
https://github.com/khizmax/libcds/pulls

@AlexPeshkoff
Copy link
Member

@mariuz I know that libcds is unmaintained. Not good, but not too big trouble - we already have unmaintained btyacc and it did not cause too big troubles for >10 years. And IMO it's not a reason to skip it's tests when porting to new hardware. For S390x & mentioned here LoongArch tests were reported to pass successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants