Fix to support the value/valueSpecified properties used by XML in Json. #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baseTwo
approved these changes
Aug 2, 2024
baseTwo
added a commit
that referenced
this pull request
Aug 5, 2024
baseTwo
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xxxx/xxxxSpecified properties were not supported correctly by the json deserializer, leading to these properties being read as their default values. This in its turn caused some properties, in this case the precision/precisionSpecified properties to return false, even if the value in the json was true. Which led to the problems in #434.
This PR now makes sure the xxxxSpecified property is set when the value is set, which means that precisionSpecified will now work correctly.
Fixes #434.