Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

428 run integration tests in build #462

Merged
merged 38 commits into from
Aug 15, 2024

Conversation

baseTwo
Copy link
Collaborator

@baseTwo baseTwo commented Aug 12, 2024

Work for #428 and #459

  • Remove all Cql to Elm targets (these must be dealt with in another issue)
  • More logging of environment in OptionsConsoleDumper

Changes to the build

  • Build the Cql-Sdk-All solution
  • Dumpify automatically strong-named by including StrongNamer package in the CLI project
  • Run the Elm to C# target only after the packager exe is available
  • Add another build task to run the integration tests (adds 6 minutes to the build)

@baseTwo baseTwo requested a review from richfirely August 14, 2024 14:53
@baseTwo baseTwo enabled auto-merge August 14, 2024 14:57
@baseTwo baseTwo marked this pull request as draft August 15, 2024 09:23
auto-merge was automatically disabled August 15, 2024 09:23

Pull request was converted to draft

@baseTwo baseTwo marked this pull request as ready for review August 15, 2024 10:16
@baseTwo
Copy link
Collaborator Author

baseTwo commented Aug 15, 2024

@richfirely - I have finished this PR. Integration tests are working now. I had to make some changes to the elm to c# targets file, the c# files generate on every compile, which is probably not necessary.

There is another issue to fix the two targets cql->elm and elm->c# #459

Copy link
Contributor

@richfirely richfirely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, well fix the always compile issue in another ticket

@richfirely richfirely merged commit 890550b into develop-2.0 Aug 15, 2024
2 checks passed
@richfirely richfirely deleted the 428-run-integration-tests-in-build branch August 15, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build targets for cql -> elm and elm -> c# Run integration tests in build pipeline
2 participants