Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

533 Quote strings to c#, escaping as necessary #535

Merged
merged 3 commits into from
Sep 12, 2024
Merged

533 Quote strings to c#, escaping as necessary #535

merged 3 commits into from
Sep 12, 2024

Conversation

baseTwo
Copy link
Collaborator

@baseTwo baseTwo commented Sep 12, 2024 •
edited
Loading

Work for #533
Escape strings when writing out c# literals.

e.g. before
image

after
image

@baseTwo baseTwo marked this pull request as ready for review September 12, 2024 11:47
@baseTwo baseTwo enabled auto-merge September 12, 2024 11:49
@EvanMachusak EvanMachusak self-requested a review September 12, 2024 12:11
EvanMachusak
EvanMachusak requested changes Sep 12, 2024
View reviewed changes
Copy link
Collaborator

@EvanMachusak EvanMachusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit tests for this functionality, both for QuoteString and for an actual CQL snippet. You can add a test to CqlToElmTests so you can use the MakeLibrary function to write a small snippet of CQL demonstrating the error.

@baseTwo baseTwo linked an issue Sep 12, 2024 that may be closed by this pull request
Bug - CQL Tag strings must be properly string escaped in C# #533
Closed
@baseTwo baseTwo merged commit 833b8e3 into develop-2.0 Sep 12, 2024
2 checks passed
@baseTwo baseTwo deleted the 533-bug---cql-tag-strings-must-be-properly-string-escaped-in-c branch September 12, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanMachusak EvanMachusak EvanMachusak approved these changes

@ewoutkramer ewoutkramer Awaiting requested review from ewoutkramer

@richfirely richfirely Awaiting requested review from richfirely

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug - CQL Tag strings must be properly string escaped in C#
2 participants
@baseTwo @EvanMachusak