Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

635 ensure that cqltype extension is added to all library input parameters #647

Conversation

baseTwo
Copy link
Collaborator

@baseTwo baseTwo commented Dec 4, 2024

Work for

Work

  • Add cqltype extension on all parameters (boxed in red below). Notice that the previous issue Adopt standard extension for output parameters that are a list #634 added the same extension but only for list types (boxed in cyan).
    image
  • Also include the element type if provided, except for List
  • Split the library and measure resource packaging into separate types

@baseTwo baseTwo linked an issue Dec 4, 2024 that may be closed by this pull request
@baseTwo baseTwo requested a review from alexzautke December 4, 2024 14:32
@baseTwo baseTwo requested a review from richfirely December 4, 2024 14:38
Copy link
Member

@alexzautke alexzautke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't reviewed the concrete code changes, however for input parameter it is necessary to the type parameter, especially for Intervals. Consumers need to know if it's an Interval or Interval. This should be done for lists as well, but there it's less critical.

…ry-input-parameters' of https://github.com/FirelyTeam/firely-cql-sdk into 635-ensure-that-cqltype-extension-is-added-to-all-library-input-parameters
@baseTwo baseTwo requested a review from alexzautke December 4, 2024 14:59
@baseTwo
Copy link
Collaborator Author

baseTwo commented Dec 4, 2024

Haven't reviewed the concrete code changes, however for input parameter it is necessary to the type parameter, especially for Intervals. Consumers need to know if it's an Interval or Interval. This should be done for lists as well, but there it's less critical.

I added the element type for "genericness". So Interval and List will work now where T is the Cql type

@baseTwo baseTwo marked this pull request as ready for review December 4, 2024 15:07
@baseTwo baseTwo enabled auto-merge December 4, 2024 15:07
@baseTwo
Copy link
Collaborator Author

baseTwo commented Dec 4, 2024

I removed the "genericness" for Lists, as discussed with @alexzautke

@baseTwo baseTwo merged commit 3181f05 into develop-2.0 Dec 4, 2024
2 checks passed
@baseTwo baseTwo deleted the 635-ensure-that-cqltype-extension-is-added-to-all-library-input-parameters branch December 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure that cqlType extension is added to all Library input parameters
2 participants