-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
635 ensure that cqltype extension is added to all library input parameters #647
635 ensure that cqltype extension is added to all library input parameters #647
Conversation
…added-to-all-library-input-parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't reviewed the concrete code changes, however for input parameter it is necessary to the type parameter, especially for Intervals. Consumers need to know if it's an Interval or Interval. This should be done for lists as well, but there it's less critical.
…ry-input-parameters' of https://github.com/FirelyTeam/firely-cql-sdk into 635-ensure-that-cqltype-extension-is-added-to-all-library-input-parameters
I added the element type for "genericness". So Interval and List will work now where T is the Cql type |
I removed the "genericness" for Lists, as discussed with @alexzautke |
Work for
Work