Engine: Better resolve handling for search parameters of type 'reference' #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennethmyhra
force-pushed
the
r4/resolve-reference
branch
from
babf342
to
e5f079b
Compare
kennethmyhra
force-pushed
the
r4/resolve-reference
branch
from
e5f079b
to
41f4b11
Compare
|
I think it is better to put the |
|
I agree, I did it for the time being to not force a major version bump since we then are breaking binary compatibility by changing the IFhirModel interface. But maybe it's time for that anyways. |
|
Oh,I see. |
kennethmyhra
force-pushed
the
r4/resolve-reference
branch
4 times, most recently
from
62d35b5
to
503b619
Compare
kennethmyhra
changed the title
This enhances our resolve handling for reference types profoundly. This adds ResourceResolver and makes use of FhirEvalutionContext.ElementResolver to wire up ResourceResolver.Resolve() in IndexService. Co-authored-by: haowang <593301179@qq.com>
kennethmyhra
force-pushed
the
r4/resolve-reference
branch
from
d1a4cd2
to
c31c1ba
Compare
Co-authored-by: haowang <593301179@qq.com>
New backup image after better resolve handling for reference types in IndexService.
kennethmyhra
force-pushed
the
r4/resolve-reference
branch
from
c31c1ba
to
614f8f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this to take effect on existing implementations it is necessary to rebuild the index by using the Admin UI that comes with Spark.Web or wire up
IndexRebuildServicein your implementaion.Se independent commits for details.
Resolves #436
Resolves #521
Resolves #522
Resolves #526
Co-authored-by: @whyfate