Change Guzzle HTTP Adapter to PSR Adapter #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should be able to use No promises though! |
|
@marczhermo Could you please have a look at your Docker container, to update the PHP version to 7.3+, and maybe/possibly PHP8 as a secondary build track? |
marczhermo
reviewed
Apr 30, 2022
| @@ -17,6 +17,8 @@ | |||
| use Firesphere\SolrSearch\Traits\CoreServiceTrait; | |||
| use GuzzleHttp\Client as GuzzleClient; | |||
| use GuzzleHttp\HandlerStack; | |||
| use Http\Discovery\HttpClientDiscovery; | |||
There was a problem hiding this comment.
Hi @Firesphere,
Can we add php-http/discovery:^1.14 to composer.json?
I got this error below:
[Emergency] Uncaught Error: Class 'Http\Discovery\HttpClientDiscovery' not found
|
Hey Marco, I've added and updated this PR, it's now ready to go. Test failing is unrelated and work locally, I'll fix up the tests on master when I get to it. This adds:
|
require at least PHP7.3 Solr 9 compatibility Flatten hierarchy to avoid Solr thinking it's a child document Add required PSR adapters
Firesphere
force-pushed
the
hans/guzzle-to-psr
branch
from
010f66e
to
a9317d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there and thank you for taking the time and effort to make a Pull Request
No, seriously, we are delighted you made time and effort to help us, even in the smallest way!
Please check the following