Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clock display #39

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Remove clock display #39

merged 2 commits into from
Dec 15, 2021

Conversation

rdsuel
Copy link

@rdsuel rdsuel commented Dec 13, 2021

Background:
Product management wants the time of day screen removed. This PR removes it.

Definition of done:

  • Remove "Time" from the settings display.
  • Remove references to the time screen from the code.

QA:

  • Verify that the time of day is gone using a gen 2 pizza oven.

Copy link

@BobbyLindsey BobbyLindsey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, pending test on an oven.

@@ -83,7 +83,6 @@ Item {
ListElement { name: "VOLUME"; screen: "Screen_SetVolume.qml" }
ListElement { name: "DISPLAY BRIGHTNESS"; screen: "Screen_SetBrightness.qml" }
ListElement { name: "ABOUT"; screen: "Screen_About.qml" }
ListElement { name: "TIME"; screen: "Screen_SettingsTime.qml" }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rdsuel
Copy link
Author

rdsuel commented Dec 14, 2021

@BobbyLindsey I've confirmed the time gone on the gen 2 oven.

@rdsuel rdsuel merged commit c183111 into biggerScreen Dec 15, 2021
@rdsuel rdsuel deleted the RemoveClock branch December 15, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants