fixup: always use destroy(err) instead of emit

See nodejs/node#29653
Fishrock123 · Sep 23, 2019 · bd6a3d1 · bd6a3d1
1 parent 7e2ec35
commit bd6a3d1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/helpers/readable-sink.js b/helpers/readable-sink.js
@@ -84,7 +84,7 @@ class ReadableSink extends Readable {
     if (error !== null) {
       if (this[kErrored] === false) {
         this[kErrored] = true
-        process.nextTick(_ => this.emit('error', error))
+        this.destory(error)
       }
       return
     }
@@ -111,7 +111,7 @@ class ReadableSink extends Readable {
 
     // If we get to here something is very wrong.
     error = new Error(`ReadableSink: Invalid status without an error: ${status}`)
-    process.nextTick(_ => this.emit('error', error))
+    this.destory(error)
   }
 }
 

diff --git a/helpers/writable-source.js b/helpers/writable-source.js
@@ -48,7 +48,7 @@ class WritableSource extends Writable {
       if (this[kFinalCallback] === null) {
         // _write should not have happened.
         const error = new Error('write happened but stream was ended without a final callback')
-        process.nextTick(_ => this.emit('error', error))
+        this.destory(error)
       }
       return
     }