Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SRE-3022-make-alb-creation-optional-in-terraform-aws-ecs-service-module #44

Merged
merged 2 commits into from
Aug 7, 2024
Merged

SRE-3022-make-alb-creation-optional-in-terraform-aws-ecs-service-module #44

merged 2 commits into from
Aug 7, 2024

Conversation

SaiPrasannaGopularam
Copy link
Contributor

Changes

  • Making the loadbalancer creation optional in this module is required for contentkeeper-cms
  • Made sure these changes will not disrupt the already existing projects using this module

@SaiPrasannaGopularam SaiPrasannaGopularam requested a review from a team as a code owner August 7, 2024 13:23
@SaiPrasannaGopularam
Copy link
Contributor Author

SaiPrasannaGopularam commented Aug 7, 2024 •
edited
Loading

Payments paln: requires alb to be created in module

No changes. Your infrastructure matches the configuration.

jamiepedwards
jamiepedwards requested changes Aug 7, 2024
View reviewed changes
alb.tf Outdated Show resolved Hide resolved
@SaiPrasannaGopularam SaiPrasannaGopularam merged commit b5ea75b into master Aug 7, 2024
@SaiPrasannaGopularam SaiPrasannaGopularam deleted the SRE-3022-make-alb-creation-optional-in-terraform-aws-ecs-service-module branch August 7, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiepedwards jamiepedwards jamiepedwards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SaiPrasannaGopularam @jamiepedwards