Add editable banner to the top of the site #589
Conversation
app/Helpers/helpers.php
Outdated
| * | ||
| * @return array | ||
| */ | ||
| public static function getAnnouncement() { |
There was a problem hiding this comment.
On second thought @AlanJIsaacson , we should probably change this method name to something like getGlobalAnnouncement.
It will also need changing in the blade template file.
| @@ -47,8 +47,30 @@ | |||
|
|
|||
|
|
|||
| <!-- Nav bars --> | |||
|
|
|||
| @if( | |||
| (!empty(SiteHelper::getAnnouncement()['data'][0]['status']) && SiteHelper::getAnnouncement()['data'][0]['status'] == 'published') | |||
There was a problem hiding this comment.
It would be useful to add a comment in here explaining what the code is for, e.g.
{{-- If the client has a global announcement published in the CMS, then output it at the top of the page --}}
|
This is quite useful for announcements, but if the museum is having any planned downtime for some of the internal services run off their infrastructure, you may not even get to the site. There's api driven calls to solr, a couple of proxied apis - these were too expensive to run on aws hardware at the level needed. I would suggest |
I have tested locally with both a published banner and then a draft.
The page behaves as expected.
Miro has said that he can tidy up the inline styles for me when he is working on frontend work next week.
I have updated the background colour for WCAG AA.
Instructions for this will need adding to the Docs site too.