Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow including extra spec keys for deployments #292

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Nov 13, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have bumped the version number in /charts/flagsmith/Chart.yaml in the section version or I'm merging to a
    release branch

Changes

Closes #291.

This allows to add arbitrary keys to both of the deployment's specs.

How did you test this code?

Added corresponding keys to values.yaml and observed the resulting template.

@khvn26 khvn26 requested a review from a team as a code owner November 13, 2024 20:31
@khvn26 khvn26 requested review from matthewelwell and removed request for a team November 13, 2024 20:31
@khvn26 khvn26 merged commit f29c242 into main Nov 15, 2024
1 check passed
@khvn26 khvn26 deleted the feat/extra-spec branch November 15, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow specifying topologySpreadConstraints in chart output
2 participants