Ensure polling thread is resilient to errors and exceptions #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewelwell
previously requested changes
Sep 7, 2023
There was a problem hiding this comment.
Thanks @goncalossilva, this looks great. I've added one minor comment requesting another test case but otherwise, all good from me.
goncalossilva
force-pushed
the
goncalossilva/polling-resiliency
branch
from
82b3e5c
to
022a9fd
Compare
|
@matthewelwell Thanks for the quick review! Added handling for |
goncalossilva
changed the title
goncalossilva
force-pushed
the
goncalossilva/polling-resiliency
branch
from
022a9fd
to
0a4768c
Compare
khvn26
reviewed
Sep 7, 2023
khvn26
requested changes
Sep 7, 2023
khvn26
reviewed
Sep 7, 2023
Co-authored-by: Kim Gustyr <khvn26@gmail.com>
goncalossilva
force-pushed
the
goncalossilva/polling-resiliency
branch
from
0a3ff91
to
e494134
Compare
khvn26
requested changes
Sep 8, 2023
Co-authored-by: Kim Gustyr <khvn26@gmail.com>
|
@matthewelwell @khvn26 all requested changes were applied. Should we merge this? :) |
khvn26
dismissed
matthewelwell’s stale review
The outstanding comment was addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flagsmith's polling thread is not resilient to API errors. If for whatever reason the API response isn't a 200,
FlagsmithAPIErroris thrown and never caught, leaving the SDK running with a dead a polling thread and consequently stale data, even if the source of the error is addressed in the meantime.Note: There are many ways to bake resiliency into this. This made the most sense to me, but you are welcome to tweak the existing code as you see fit.