Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Improve coverage performance #3825

Merged
merged 2 commits into from
Apr 24, 2024
Merged

chore(ci): Improve coverage performance #3825

merged 2 commits into from
Apr 24, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Apr 23, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Based on this coverage-py issue here, we switch to sys.monitoring based coverage which heavily improves the unit tests performance.

How did you test this code?

This is a CI change.

Copy link

vercel bot commented Apr 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:45pm
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:45pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 2:45pm

Copy link
Contributor

github-actions bot commented Apr 23, 2024

Uffizzi Preview deployment-50660 was deleted.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.91%. Comparing base (5068575) to head (a32a06e).

❗ Current head a32a06e differs from pull request most recent head 3c0536f. Consider uploading reports for the commit 3c0536f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3825   +/-   ##
=======================================
  Coverage   95.91%   95.91%           
=======================================
  Files        1122     1122           
  Lines       35482    35482           
=======================================
  Hits        34034    34034           
  Misses       1448     1448           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit f9ec0b6 Apr 24, 2024
22 checks passed
@khvn26 khvn26 deleted the chore/speedup-coverage branch April 24, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants