Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error validating MSOL enum method #25

Closed
tuxnam opened this issue Feb 28, 2023 · 1 comment
Closed

Error validating MSOL enum method #25

tuxnam opened this issue Feb 28, 2023 · 1 comment

Comments

@tuxnam
Copy link

tuxnam commented Feb 28, 2023

In the --validate-msol method, you check the following, to see if GetCredentialType is supported or not:

if (!string.IsNullOrEmpty(postRespObject.EstsProperties?.CallMetadata?.HisRegion))

However, CallMetadata and HisRegion are not (anymore at least) part of the EstsProperties key from my research.
It will rather give you two main properties: UserTenantBranding and DomainType.
This is based on the triplet DomainType, ThrottleStatus and IfExistsResult that you will be able to see if you can enumerate accounts or not.
Your current way of checking will give "not supported" for probably all tenants today, while it is supported for part of them.

@Flangvik
Copy link
Owner

Flangvik commented Mar 7, 2023

Thanks for the input, as you point out, seems MS has been making changes since this was implemented. i'll make sure this get fixed near future (i'm currently working on a massive update so trying to avoid maing to many changes to the current online repo)

Flangvik pushed a commit that referenced this issue Apr 11, 2023
Added error handling for email format selection
Updated nuget packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants