Email exists but the database does not get populated

[thehackerish]

I am using the Teams technique in TeamFiltration. Using the Debug option, I see that some emails return a valid TenantId and that the email is valid and found in many attributes in the JSON response. However, the UserPrincipalName does not match the username, but the givenName matches the email.

Here is an example for the username d.bauer@redacted.com. I anonymized all the data.

[{"tenantId":"REDACTED","isShortProfile":false,"accountEnabled":true,"featureSettings":{"coExistenceMode":"TeamsOnly"},"userPrincipalName":"d19@redacted.com","givenName":"d.bauer@redacted.com","surname":"","email":"d19@redacted.com","tenantName":"REDACTED","displayName":"Dave Bauer","type":"Federated","mri":"8:orgid:REDACTED","objectId":"REDACTED"}]

I was wondering why do you check that the UserPrincipalName should be equal to the email in this line:

TeamFiltration/TeamFiltration/TeamFiltration/Handlers/TeamsHandler.cs

Line 199 in e125f79

&& responeObject.FirstOrDefault().userPrincipalName.ToLower().Equals(username.ToLower())

[Flangvik]

This is a good find 👍👍Just what I wanted when releasing this (it being used against more clients, thus seeing more tenant configs and edge cases). Thinking the best approach would be to merge those into an or statement, comparing both the givenName and userPrincipalName properties to the username.

Also 10+ points for using the debug feature ;)

[thehackerish]

Perfect! I will add a pull request considering what I have in my tests. The approach would be to look for the email in all attributes of the objects in the list returned and store it if it matches any.

[AntonyBwana]

In my case I was using the MSOL module. I realised that the emails that have been verified aren't being stored.

[sadpotatos123]

In my case I was using the MSOL module. I realised that the emails that have been verified aren't being stored.

I had the same problem when using --validate-msol.

[Flangvik]

Should be fixed in https://github.com/Flangvik/TeamFiltration/releases/tag/v3.5.3