Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if email is valid using Teams and a relaxed logic #37

Conversation

thehackerish
Copy link

Verify if the email is valid using Teams and a more relaxed logic.

Solves the issue in #36

@Flangvik
Copy link
Owner

I have a feeling this might be a bit to relaxed , causing way to many false positives. I'll do some more wide scoped testing, however thanks for the pr!

@thehackerish
Copy link
Author

thehackerish commented May 25, 2023

My pleasure, great project! Good job!
Yeah I was thinking of reverting to your first two verifications and then defining a whitelist of attributes like UPN, GivenName, etc. and test them inside the function. Would that be ok for you? Otherwise, I will work with my version and wait for your update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants