Issue #484: Name with ':' breaks in windows

Flank · Feb 1, 2019 · 58d84bc · 58d84bc
1 parent 5831773
commit 58d84bc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/test_runner/src/main/kotlin/ftl/util/Utils.kt b/test_runner/src/main/kotlin/ftl/util/Utils.kt
@@ -69,7 +69,7 @@ object Utils {
         val instant = Instant.now()
 
         bucketName.append(
-            DateTimeFormatter.ofPattern("yyyy-MM-dd_HH:mm:ss.")
+            DateTimeFormatter.ofPattern("yyyy-MM-dd_HH-mm-ss.")
                 .withZone(ZoneOffset.UTC)
                 .format(instant)
         )

diff --git a/test_runner/src/test/kotlin/ftl/util/UtilsTest.kt b/test_runner/src/test/kotlin/ftl/util/UtilsTest.kt
@@ -23,6 +23,19 @@ class UtilsTest {
         assertThat(Utils.readTextResource("version.txt")).isNotNull()
     }
 
+    @Test
+    fun uniqueObjectName_verifyPattern() {
+        val randomName = Utils.uniqueObjectName()
+        assertThat(randomName.length).isEqualTo(32)
+        assertThat(randomName[4]).isEqualTo('-')
+        assertThat(randomName[7]).isEqualTo('-')
+        assertThat(randomName[10]).isEqualTo('_')
+        assertThat(randomName[13]).isEqualTo('-')
+        assertThat(randomName[16]).isEqualTo('-')
+        assertThat(randomName[19]).isEqualTo('.')
+        assertThat(randomName[26]).isEqualTo('_')
+    }
+
     @Test
     fun testExitCodeForFailed() {
         val testExecutions = listOf(