Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI support for all args #365

Closed
34 tasks done
bootstraponline opened this issue Oct 23, 2018 · 2 comments
Closed
34 tasks done

CLI support for all args #365

bootstraponline opened this issue Oct 23, 2018 · 2 comments

Comments

@bootstraponline
Copy link
Contributor

bootstraponline commented Oct 23, 2018

Match gcloud CLI in providing CLI arguments for all options.

Android

iOS

All

Edge cases

  • Test single value environment variable clearPackageData . Expected to be in KEY=VALUE format.

Workflow for adding an Android only param:

AndroidRunCommand

  • doc from gcloud + nullable default

AndroidArgs.kt

  • cli.param ?: yaml.param

AndroidArgsTest.kt

  • minimal YAML, verify cli overrides yaml value

AndroidRunCommandTest.kt

  • empty_params_parse_null - update to verify default value is null
  • add param_parse test to verify command is parsed correctly.

Workflow for adding an iOS param

IosRunCommand

  • Doc from gcloud + nullable default

IosArgs

  • cli?.param ?: yaml.param

IosArgsTest

  • Minimal YAML, verify cli overrides yaml value

IosRunCommandTest

  • empty_params_parse_null - update to verify default value is null
  • Add param_parse test to verify command is parsed correctly.
@bootstraponline bootstraponline changed the title CLI support for all args Macarse | CLI support for all args Oct 24, 2018
@Macarse
Copy link
Contributor

Macarse commented Nov 14, 2018

@bootstraponline just fyi. I don't have permission to edit the checkboxes and/or add the PR number.

@bootstraponline
Copy link
Contributor Author

I added you to the repo 🙂 you should have permission now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants