--test-targets param #394
Merged
--test-targets param #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
| @Test | ||
| fun testTargets_parse() { | ||
| val cmd = AndroidRunCommand() | ||
| CommandLine(cmd).parse("--test-targets", "class com.foo.Clazz", "--test-targets", "package com.my.package") |
There was a problem hiding this comment.
probably better to extract "class com.foo.Clazz", "--test-targets", "package com.my.package" to a variable.
I think you can make them a list and then destructure with *.
val expectedTargets = listOf("class com.foo.Clazz", "--test-targets", "package com.my.package")
...| @Test | ||
| fun androidArgs_overrideTestTargetsFromCmdLine() { | ||
| val cli = AndroidRunCommand() | ||
| CommandLine(cli).parse("--test-targets", "class com.foo.ClassName") |
There was a problem hiding this comment.
extract "class com.foo.ClassName" to a variable
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
============================================
+ Coverage 79.93% 79.94% +0.01%
- Complexity 479 480 +1
============================================
Files 66 66
Lines 1550 1551 +1
Branches 234 234
============================================
+ Hits 1239 1240 +1
Misses 173 173
Partials 138 138 |
bootstraponline
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#365