Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing help command #2020

Merged
merged 7 commits into from
Jun 10, 2021
Merged

fix: Added missing help command #2020

merged 7 commits into from
Jun 10, 2021

Conversation

adamfilipow92
Copy link
Contributor

Fixes #1826

Test Plan

How do we know the code works?

  1. All tests pass
  2. All commands displays help

Checklist

  • Unit tested

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2021

Timestamp: 2021-06-09 15:07:26
Buildscan url for ubuntu-workflow run 922145456
https://gradle.com/s/gjslimbnupqks

@adamfilipow92 adamfilipow92 marked this pull request as ready for review June 9, 2021 11:46
@bootstraponline bootstraponline force-pushed the 1826-add-missing-help branch from e3924ec to 42d59dd Compare June 9, 2021 12:33
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamfilipow92 Does each command actually have a help description or do they all print out "Prints this help message"?

@adamfilipow92
Copy link
Contributor Author

@adamfilipow92 Does each command actually have a help description or do they all print out "Prints this help message"?

All commands have a help description. Here is an example:

flank.jar
 [-hv] [--debug] [COMMAND]
      --debug     Enables debug logging
  -h, --help      Prints this help message
  -v, --version   Prints the version
Commands:
  firebase
  corellium
  ios
  android
  refresh            Downloads results for the last Firebase Test Lab run
  cancel             Cancels the last Firebase Test Lab run
  auth               Manage oauth2 credentials for Google Cloud
  provided-software
  network-profiles   Explore network profiles available for testing.
  ip-blocks          Explore IP blocks used by Firebase Test Lab devices.

Total run duration: 0m  0s

As you see Prints this help message describes help parameters.

@adamfilipow92 adamfilipow92 requested a review from Sloox June 10, 2021 12:04
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit e7b6324 into master Jun 10, 2021
@mergify mergify bot deleted the 1826-add-missing-help branch June 10, 2021 12:21
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add -h help flag to all commands
4 participants