Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement slack notifications for failed release #2047

Merged
merged 3 commits into from
Jun 28, 2021
Merged

feat: Implement slack notifications for failed release #2047

merged 3 commits into from
Jun 28, 2021

Conversation

pawelpasterz
Copy link
Contributor

@pawelpasterz pawelpasterz commented Jun 25, 2021 •
edited
Loading

Fixes #2006

What was done?

  • 3 new secrets for failure slack notification
  • notifications added in crucial release workflows
  • PR checks should not be performed for release notes

Test Plan

How do we know the code works?

This is impossible to verify PR prior to its merge.

@pawelpasterz pawelpasterz self-assigned this Jun 25, 2021
Sloox
Sloox approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2021 •
edited
Loading

Timestamp: 2021-06-28 18:13:21
Buildscan url for ubuntu-workflow run 979956138
https://gradle.com/s/3xmk33ubqac6m

@pawelpasterz pawelpasterz marked this pull request as ready for review June 28, 2021 05:52
@pawelpasterz pawelpasterz enabled auto-merge (squash) June 28, 2021 06:46
Sloox
Sloox approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@Sloox Sloox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont see any issues, however Its very hard to test until merged.

adamfilipow92
adamfilipow92 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@adamfilipow92 adamfilipow92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pawelpasterz pawelpasterz merged commit eef1448 into master Jun 28, 2021
@pawelpasterz pawelpasterz deleted the 2006-slack-notification-for-failed-release branch June 28, 2021 18:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotradamczyk5 piotradamczyk5 piotradamczyk5 approved these changes

@adamfilipow92 adamfilipow92 adamfilipow92 approved these changes

@Sloox Sloox Sloox approved these changes

Assignees

@pawelpasterz pawelpasterz

Labels
Feature Infrastructure Tiger 🐯
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flank Release Failure Slack Notification
4 participants
@pawelpasterz @Sloox @adamfilipow92 @piotradamczyk5