Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateMatrixFile #534

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Fix updateMatrixFile #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9743960
Fix updateMatrixFile
bootstraponline Mar 29, 2019
7e8fa5a
Update release_notes.md
bootstraponline Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

-

## v5.0.1

- [#534](https://github.com/TestArmada/flank/pull/534) Fix updateMatrixFile not saving `matrix_ids.json`. ([bootstraponline](https://github.com/bootstraponline))

## v5.0.0

- [#506](https://github.com/TestArmada/flank/pull/506) Add bugsnag reporting to detect Flank crashes. ([bootstraponline](https://github.com/bootstraponline))
Expand Down
8 changes: 2 additions & 6 deletions test_runner/src/main/kotlin/ftl/run/TestRunner.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,8 @@ object TestRunner {

while (true) {
refreshedMatrix = GcTestMatrix.refresh(matrixId, args)
// Update the matrix file when the matrix is updated
if (matrices.map[matrixId]?.update(refreshedMatrix) == true) updateMatrixFile(matrices, args)

val firstTestStatus = refreshedMatrix.testExecutions.first()

Expand Down Expand Up @@ -333,12 +335,6 @@ object TestRunner {
puts(lastState)
}

// Update the matrix file if the matrix has changed.
val changed = matrices.map[matrixId]?.update(refreshedMatrix) ?: false
if (changed) {
updateMatrixFile(matrices, args)
}

// GetTestMatrix is not designed to handle many requests per second.
// Sleep 15s to avoid overloading the system.
Utils.sleep(15)
Expand Down