Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use legacy results for iOS by default #783

Merged
merged 2 commits into from
May 14, 2020
Merged

Use legacy results for iOS by default #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cc1b7c
Use legacy results for iOS by default
pawelpasterz May 14, 2020
7ba9d31
Update release notes
pawelpasterz May 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
## next (unreleased)
-
- [#783](https://github.com/Flank/flank/pull/783) Use legacy results for iOS by default. ([pawelpasterz](https://github.com/pawelpasterz))

## v20.05.1

Expand Down
2 changes: 2 additions & 0 deletions test_runner/src/main/kotlin/ftl/args/IosArgs.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ class IosArgs(
override val networkProfile = cli?.networkProfile ?: gcloud.networkProfile
override val ignoreFailedTests = cli?.ignoreFailedTests ?: flank.ignoreFailedTests
override val keepFilePath = cli?.keepFilePath ?: flank.keepFilePath
// currently, FTL does not provide API based results for iOS
override val useLegacyJUnitResult = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix. Shame on me :/


private val iosFlank = iosFlankYml.flank
val testTargets = cli?.testTargets ?: iosFlank.testTargets.filterNotNull()
Expand Down
1 change: 1 addition & 0 deletions test_runner/src/test/kotlin/ftl/args/IosArgsTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ flank:
assert(flakyTestAttempts, 4)
assert(disableSharding, true)
assert(runTimeout, "15m")
assert(useLegacyJUnitResult, true)
}
}

Expand Down