Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adds check for python versions below 3.9 and bails out if tru… #84

Closed
wants to merge 1 commit into from

Conversation

markkasaboski
Copy link
Collaborator

…e (#81)"

This reverts commit c2132f7.

@aviau I realized that this isn't going to work because we end up getting a syntax errors before this is ever run.

@markkasaboski markkasaboski requested a review from aviau February 7, 2025 21:53
@markkasaboski markkasaboski self-assigned this Feb 7, 2025
@aviau
Copy link
Member

aviau commented Feb 8, 2025

@aviau I realized that this isn't going to work because we end up getting a syntax errors before this is ever run.

Interesting, can I see it?

@aviau
Copy link
Member

aviau commented Feb 8, 2025

Feel free to merge anyways

@markkasaboski
Copy link
Collaborator Author

@aviau I realized that this isn't going to work because we end up getting a syntax errors before this is ever run.

Interesting, can I see it?

Screenshot 2025-02-10 at 10 19 54 AM

@markkasaboski
Copy link
Collaborator Author

@aviau Ah! I need to add it to the other python files as well:

Screenshot 2025-02-10 at 10 22 47 AM

@markkasaboski
Copy link
Collaborator Author

Closing this revert. This PR includes the check in the other two .py files and see the message in the internal logs as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants