Feature/planning/schedule sensor with different units #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
…ower sensor. Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
… and soc-min, soc-max and soc-at-start in kWh and MWh. Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
victorgarcia98
added
enhancement
Flix6x
requested changes
Jul 25, 2024
| data_key="soc-min", | ||
| default_src_unit="MWh", | ||
| to_unit="MWh", | ||
| validate=validate.Range(min=0), |
There was a problem hiding this comment.
The validator is used on the deserialized value, which I believe would fail in case a string quantity definition has been deserialized to a quantity object, and is then compared to zero.
Comment on lines
+295
to
+297
| NB any validators passed are only applied to Quantities. | ||
| For example, validate=validate.Range(min=0) will raise a ValidationError in case of negative quantities, | ||
| but will let pass any sensor that has recorded negative values. |
There was a problem hiding this comment.
Copy pasted without being adapted.
| super().__init__(*args, **kwargs) | ||
| if _validate is not None: | ||
| # Insert validation into self.validators so that multiple errors can be stored. | ||
| validator = RepurposeValidatorToIgnoreSensors(_validate) |
Actually, my PR doesn't address this, so this is something extra worth cherry-picking from your PR. |
9 tasks
|
After including the missing pieces from this PR to #1127, we can close this PR and finalize the work on PR #1127 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR opens the door for scheduling in any power units, for example, in kW. Two changes were introduced for this purpose:
soc-min,soc-maxandsoc-at-startin arbitrary energy units.Pending tasks
Related Items
Closes #386