Issue 450 api option to customize which price and power sensors to take into account for scheduling #451

Flix6x · 2022-06-24T15:43:24Z

This PR introduces three optional fields to the sensors/(id)/schedules/trigger endpoint to allow further customization of optimization context:

consumption-price-sensor: prices upward deviations from previous zero-consumption commitments
~~feed-in-price-sensor~~ production-price-sensor: prices downward deviations from previous zero-consumption commitments
inflexible-device-sensors: their power forecasts are included in the aggregate load

I included an automated test for the battery solver within the optimization context of a building in which solar PV is present, which limits the battery's headroom to discharge.

Another automated test I envision is still missing, for a setting in which the feed-in price is significantly lower than the consumption price, which motivates maximizing self-consumption.

Closes #450 (which contains our initial discussion).

Next steps are:

…sumption and feed-in Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>

coveralls · 2022-06-24T17:17:03Z

Pull Request Test Coverage Report for Build 2920131604

51 of 58 (87.93%) changed or added relevant lines in 9 files are covered.
214 unchanged lines in 14 files lost coverage.
Overall coverage increased (+0.2%) to 67.717%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
flexmeasures/data/models/planning/utils.py	10	11	90.91%
flexmeasures/cli/data_add.py	3	6	50.0%
flexmeasures/data/models/planning/charging_station.py	11	14	78.57%

Files with Coverage Reduction	New Missed Lines	%
flexmeasures/data/models/planning/utils.py	1	83.33%
flexmeasures/api/v3_0/assets.py	3	95.4%
flexmeasures/data/models/data_sources.py	3	52.56%
flexmeasures/ui/views/new_dashboard.py	3	90.0%
flexmeasures/ui/init.py	4	94.12%
flexmeasures/data/services/asset_grouping.py	11	77.0%
flexmeasures/data/queries/utils.py	16	62.5%
flexmeasures/utils/time_utils.py	16	76.55%
flexmeasures/api/dev/sensors.py	17	61.33%
flexmeasures/api/v1_2/implementations.py	19	75.16%

Totals
Change from base Build 2679559260:	0.2%
Covered Lines:	7247
Relevant Lines:	10133

💛 - Coveralls

…include in the aggregate power flow Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>

… headroom with respect to the PV system's nominal capacity Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>

…flexible devices Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>

…e_and_power_sensors_to_take_into_account_for_scheduling

…e_and_power_sensors_to_take_into_account_for_scheduling # Conflicts: # flexmeasures/cli/data_add.py # flexmeasures/data/services/scheduling.py

flexmeasures/api/v3_0/sensors.py

flexmeasures/cli/data_add.py

flexmeasures/data/models/planning/charging_station.py

flexmeasures/data/models/planning/solver.py

flexmeasures/data/models/planning/tests/conftest.py

flexmeasures/data/models/planning/utils.py

…uling Signed-off-by: F.N. Claessen <felix@seita.nl>

…heduling Signed-off-by: F.N. Claessen <felix@seita.nl>

…fined in the conftest) are measurements rather than forecasts Signed-off-by: F.N. Claessen <felix@seita.nl>

…casts to be present Signed-off-by: F.N. Claessen <felix@seita.nl>

…one instead of UTC Signed-off-by: F.N. Claessen <felix@seita.nl>

…in the Europe/Amsterdam timezone instead of UTC Signed-off-by: F.N. Claessen <felix@seita.nl>

Signed-off-by: F.N. Claessen <felix@seita.nl>

…consumption of the devices, instead of being applied to the consumption of the single flexible device under consideration. Likewise for production. Signed-off-by: F.N. Claessen <felix@seita.nl>

nhoening

I like it.
I don't think I have big requests, should be possible to bring into 0.11. Well, you decide.

flexmeasures/api/v3_0/sensors.py

flexmeasures/data/models/planning/battery.py

flexmeasures/data/models/planning/utils.py

flexmeasures/api/v3_0/sensors.py

Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x · 2022-08-24T15:08:56Z

I still have to open up some new issues corresponding to open discussions in this PR, but would you now approve this PR code-wise?

Flix6x added 2 commits June 24, 2022 17:41

Add optional API fields to specify which price sensors to use for con…

9cd08cd

…sumption and feed-in Signed-off-by: F.N. Claessen <felix@seita.nl>

Rename API fields

7acb199

Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x added API Scheduling labels Jun 24, 2022

Flix6x self-assigned this Jun 24, 2022

Flix6x added 14 commits June 28, 2022 13:35

Add optional API field to specify which inflexible device sensors to …

51551c0

…include in the aggregate power flow Signed-off-by: F.N. Claessen <felix@seita.nl>

Add test data for inflexible device

cdf2055

Signed-off-by: F.N. Claessen <felix@seita.nl>

Add test case for scheduling a battery including an inflexible device

7fd16c3

Signed-off-by: F.N. Claessen <felix@seita.nl>

Fix boundary conditions for including inflexible devices

dd2c454

Signed-off-by: F.N. Claessen <felix@seita.nl>

Assume perfect efficiency if no efficiency information is available

c17bf95

Signed-off-by: F.N. Claessen <felix@seita.nl>

Switch from random periodic data to a step function, leaving a little…

dde07db

… headroom with respect to the PV system's nominal capacity Signed-off-by: F.N. Claessen <felix@seita.nl>

Return test data with conftest setup

973bf87

Signed-off-by: F.N. Claessen <felix@seita.nl>

Skip redundant sensor queries in tests

96981de

Signed-off-by: F.N. Claessen <felix@seita.nl>

Refactor: rename variable for clarity

418c186

Signed-off-by: F.N. Claessen <felix@seita.nl>

Take into account the nominal capacity of the asset, if given

fc7f08a

Signed-off-by: F.N. Claessen <felix@seita.nl>

Refactor: rename variable in test

ef6d5c0

Signed-off-by: F.N. Claessen <felix@seita.nl>

Convert consumption/production power sign for our scheduler

170be64

Signed-off-by: F.N. Claessen <felix@seita.nl>

Split fixtures, set up the building with a flexible device and two in…

116d422

…flexible devices Signed-off-by: F.N. Claessen <felix@seita.nl>

Test building solver

b04401d

Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x marked this pull request as ready for review July 19, 2022 21:43

Flix6x added 2 commits July 19, 2022 23:46

Merge branch 'main' into Issue-450_API_option_to_customize_which_pric…

e9b3338

…e_and_power_sensors_to_take_into_account_for_scheduling

Merge branch 'main' into Issue-450_API_option_to_customize_which_pric…

4e90f39

…e_and_power_sensors_to_take_into_account_for_scheduling # Conflicts: # flexmeasures/cli/data_add.py # flexmeasures/data/services/scheduling.py

Flix6x requested a review from nhoening July 19, 2022 21:53

nhoening requested changes Jul 30, 2022

View reviewed changes

Flix6x added 5 commits August 8, 2022 15:55

Fix passing along list of inflexible device sensors for battery sched…

8c343dc

…uling Signed-off-by: F.N. Claessen <felix@seita.nl>

Restrict data used for scheduling to what was known at the time of sc…

bb01440

…heduling Signed-off-by: F.N. Claessen <felix@seita.nl>

Fix tests, given that the values for solar PV and residual demand (de…

38ceee6

…fined in the conftest) are measurements rather than forecasts Signed-off-by: F.N. Claessen <felix@seita.nl>

Let test schedule the future instead of the past, which requires fore…

0c9e886

…casts to be present Signed-off-by: F.N. Claessen <felix@seita.nl>

Set up test data for inflexible devices in the Europe/Amsterdam timez…

3a95f86

…one instead of UTC Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x added 9 commits August 8, 2022 17:26

Set up test data for EPEX market prices in the Europe/Amsterdam timez…

38e87c0

…one instead of UTC Signed-off-by: F.N. Claessen <felix@seita.nl>

Fix scheduling tests corresponding to having market prices available …

e0a1507

…in the Europe/Amsterdam timezone instead of UTC Signed-off-by: F.N. Claessen <felix@seita.nl>

black

46969c7

Signed-off-by: F.N. Claessen <felix@seita.nl>

Add comment from earlier commit

9151e94

Signed-off-by: F.N. Claessen <felix@seita.nl>

Clear up inline comment

b6bb9ae

Signed-off-by: F.N. Claessen <felix@seita.nl>

Rename variable internally

e41c0ae

Signed-off-by: F.N. Claessen <felix@seita.nl>

Rename API field

fdaaccc

Signed-off-by: F.N. Claessen <felix@seita.nl>

Rename CLI field with future deprecation warning

bd54acf

Signed-off-by: F.N. Claessen <felix@seita.nl>

Clarify that the consumption price is being applied to the aggregate …

67aadbd

…consumption of the devices, instead of being applied to the consumption of the single flexible device under consideration. Likewise for production. Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x requested a review from nhoening August 8, 2022 18:28

nhoening requested changes Aug 23, 2022

View reviewed changes

flexmeasures/api/v3_0/sensors.py Outdated Show resolved Hide resolved

flexmeasures/data/models/planning/battery.py Show resolved Hide resolved

flexmeasures/data/models/planning/utils.py Outdated Show resolved Hide resolved

flexmeasures/api/v3_0/sensors.py Outdated Show resolved Hide resolved

Flix6x added 6 commits August 24, 2022 10:36

Clarify description of aggregate power flow

be58a3f

Signed-off-by: F.N. Claessen <felix@seita.nl>

Add return type annotation

fcbbc7d

Signed-off-by: F.N. Claessen <felix@seita.nl>

Expand docstring

d429139

Signed-off-by: F.N. Claessen <felix@seita.nl>

Fix use of wrong exception

dd96b66

Signed-off-by: F.N. Claessen <felix@seita.nl>

Refactor: rename util function

d8b7f57

Signed-off-by: F.N. Claessen <felix@seita.nl>

Changelog entry

5cc79da

Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x added this to the 0.11.0 milestone Aug 24, 2022

Implement recommended docstring revision

d101e1d

Signed-off-by: F.N. Claessen <felix@seita.nl>

Flix6x mentioned this pull request Aug 24, 2022

Extend documentation and toy tutorial with scheduling within the context of a building with PV #481

Closed

Flix6x requested a review from nhoening August 24, 2022 15:09

This was referenced Aug 24, 2022

Add scheduling test for maximizing self-consumption #482

Closed

Unit validation on price sensors in optimization context #483

Open

Rename internal search filters (with deprecation warnings) #484

Open

nhoening approved these changes Aug 24, 2022

View reviewed changes

Flix6x merged commit 7ff1480 into main Aug 24, 2022

Flix6x deleted the Issue-450_API_option_to_customize_which_price_and_power_sensors_to_take_into_account_for_scheduling branch August 24, 2022 15:44

Flix6x mentioned this pull request Jan 8, 2024

Flex model fields from sensors #955

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue 450 api option to customize which price and power sensors to take into account for scheduling #451

Issue 450 api option to customize which price and power sensors to take into account for scheduling #451

Flix6x commented Jun 24, 2022 •

edited

Loading

coveralls commented Jun 24, 2022 •

edited

Loading

nhoening left a comment

Flix6x commented Aug 24, 2022

Issue 450 api option to customize which price and power sensors to take into account for scheduling #451

Issue 450 api option to customize which price and power sensors to take into account for scheduling #451

Conversation

Flix6x commented Jun 24, 2022 • edited Loading

coveralls commented Jun 24, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2920131604

💛 - Coveralls

nhoening left a comment

Choose a reason for hiding this comment

Flix6x commented Aug 24, 2022

Flix6x commented Jun 24, 2022 •

edited

Loading

coveralls commented Jun 24, 2022 •

edited

Loading