Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI/add quantity or sensor storage scheduler #966

Merged
merged 21 commits into from
Feb 6, 2024
Merged

CLI/add quantity or sensor storage scheduler #966

merged 21 commits into from
Feb 6, 2024

Conversation

victorgarcia98
Copy link
Contributor

@victorgarcia98 victorgarcia98 commented Jan 26, 2024 •
edited by Flix6x
Loading

Description

So far, the flex-model fields of type QuantityOrSensor could only be used trough the API. This PR introduces them in command flexmeasures add schedule for-storage.

How to test?

This PR introduces a new end-to-end test to check if we can trigger the storage schedule via the CLI. It is tagged to run only on a local dev environment, therefore, I would like if the reviewer could try (him/her)self the test locally.

TODO

  • Create and end-to-end test for the command flexmeasures add schedule for-storage.
  • Changelog entry.
  • CLI changelog entry.

Related Items

Closes #935

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on code under GPL or other license that is incompatible with FlexMeasures

@victorgarcia98
add QuantityOrSensor fields to the fm add storage for-schedule command
08b7039 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge branch 'main' into features/cli/add-quantity-or-sensor-storage-…
6f94a54 
…scheduler

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
use storage efficiency quatity or sensor
3978be3 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge branch 'feature/planning/storage-efficiency-from-sensor' into f…
7720fb1 
…eatures/cli/add-quantity-or-sensor-storage-scheduler
@victorgarcia98
add storage efficiency and help messages
304cd48 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 self-assigned this Jan 26, 2024
@victorgarcia98
fix issue with default value
43b7f72 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add end-to-end test
26823e9 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge branch 'main' into feature/planning/storage-efficiency-from-sensor
13d6ef5
@victorgarcia98
add changelog
09df3ab 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add docstring to fixture
3581eeb 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add docstrings to tests
9478fce 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge branch 'feature/planning/storage-efficiency-from-sensor' into f…
0e0dd7f 
…eatures/cli/add-quantity-or-sensor-storage-scheduler
@victorgarcia98
enhanced docstring for test_add_storage_scheduler
7978531 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
add changelog entries
b06b876 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98 victorgarcia98 marked this pull request as ready for review January 30, 2024 12:56
Flix6x
Flix6x reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only; I have yet to try the new CLI test locally.

flexmeasures/cli/data_add.py Outdated Show resolved Hide resolved
flexmeasures/cli/tests/conftest.py Show resolved Hide resolved
@victorgarcia98
improve docstring and clarify changelog
2ae7db7 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge branch 'feature/planning/storage-efficiency-from-sensor' into f…
e06437c 
…eatures/cli/add-quantity-or-sensor-storage-scheduler

Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
simplify re-serialization
a79cb65 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
comment failing test
1d3ce81 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@victorgarcia98
Merge branch 'feature/planning/storage-efficiency-from-sensor' into f…
6eeda77 
…eatures/cli/add-quantity-or-sensor-storage-scheduler
@victorgarcia98
rename fixture sensors
f9656a0 
Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
@Flix6x Flix6x added this to the 0.19.0 milestone Feb 5, 2024
Flix6x
Flix6x approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Flix6x Flix6x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New CLI test passes locally.

Base automatically changed from feature/planning/storage-efficiency-from-sensor to main February 6, 2024 12:00
@victorgarcia98
Merge branch 'main' into features/cli/add-quantity-or-sensor-storage-…
4ebbe21 
…scheduler

Signed-off-by: Victor <victor@seita.nl>
@victorgarcia98 victorgarcia98 merged commit 248b6dc into main Feb 6, 2024
9 checks passed
@victorgarcia98 victorgarcia98 deleted the features/cli/add-quantity-or-sensor-storage-scheduler branch February 6, 2024 12:33
@nhoening nhoening changed the title add quantity or sensor storage scheduler CLI/add quantity or sensor storage scheduler Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flix6x Flix6x Flix6x approved these changes

Assignees

@victorgarcia98 victorgarcia98

Labels
CLI
Projects
More powerful scheduling of sensors
Status: In progress
Milestone
0.19.0
Development

Successfully merging this pull request may close these issues.

Let users pass QuantityOrSensor field types to flexmeasures add schedule for-storage
2 participants
@victorgarcia98 @Flix6x