fixed missing dash in xiana.swagger #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
soulflyer
reviewed
Jan 18, 2024
| @@ -1,7 +1,7 @@ | |||
| (ns xiana.webserver | |||
| "Lifecycle management of the webserver" | |||
| (:require | |||
| [ring.adapter.jetty9 :as jetty] | |||
| [org.httpkit.server :as server] | |||
There was a problem hiding this comment.
Why do we want to change to httpkit?
|
There appear to be a number of things happening in this PR. We really need to stick to one issue per PR. |
|
Oh geez, please forgive me. I was late to see this. I really messed up this pull request. I only wanted to PR fixing the dash. SORRY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Spelling error on -get-apidocs in xiana.swagger
Description
Says it all. There was a dash missing from -get-apidocs. If you want me to put something on the changelog I'll resubmit. I'll leave it up to you if you want to track such minor things.
Xiana
I'm enjoying how minimalistic what you are doing is. Thanks for the open source.