refactor: Visitor class now use assertions

Floating-Dartists · Jul 3, 2024 · 56fcf7c · 56fcf7c
1 parent 1c7c3f2
commit 56fcf7c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 18 deletions.
diff --git a/lib/src/visitor.dart b/lib/src/visitor.dart
@@ -1,22 +1,11 @@
 class Visitor {
-  factory Visitor({
-    String? id,
-    String? uid,
-  }) {
-    if (uid != null && uid.isEmpty) {
-      throw ArgumentError('Must not be empty', 'uid');
-    }
-
-    return Visitor._(
-      id: id,
-      uid: uid,
-    );
-  }
-
-  Visitor._({
+  const Visitor({
     this.id,
     this.uid,
-  });
+  }) : assert(
+          uid == null || uid.length != 0,
+          'uid must not be empty',
+        );
 
   /// The unique visitor ID, must be a 16 characters hexadecimal string.
   ///

diff --git a/test/src/visitor_test.dart b/test/src/visitor_test.dart
@@ -5,7 +5,7 @@ import '../ressources/mock/data.dart';
 
 void main() {
   test('it should be able to create Visitor', () {
-    final visitor = Visitor(
+    const visitor = Visitor(
       id: visitorId,
       uid: uid,
     );
@@ -22,6 +22,6 @@ void main() {
       );
     }
 
-    expect(getVisitorWithEmptyUserId, throwsArgumentError);
+    expect(getVisitorWithEmptyUserId, throwsAssertionError);
   });
 }