Not much can be done #12
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So generally speaking other than using the slightly shorter array on the Bits and BinaryBits types Not much can be done regarding the unsigned int types. Your salvation may come with this proposal should the day come microsoft/TypeScript#15480 But Typescript will probably not support base uintx types as this discussion ended microsoft/TypeScript#4639 essentially JS is expecting BigInt and other types may be added someday and so no extra primitives will be added until T39 adds them on a side note this regex proposal should it get implemented would be interesting microsoft/TypeScript#6579
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 43 43
Lines 402 402
Branches 49 49
=====================================
Hits 402 402Continue to review full report at Codecov.
|
|
Hi, @amrdraz, thank you for investigating this issue. It’s really odd that typescript has such a basic limitation. I get that waiting for TC39 makes sense from a compatibility standpoint though and haven’t heard that reason before reading this issue. I’ll close the PR, since I plan to change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So generally speaking other than using the slightly shorter array on the Bits and BinaryBits types
Not much can be done regarding the unsigned int types.
Your salvation may come with this proposal should the day come microsoft/TypeScript#15480
But Typescript will probably not support base uint[n] types as this discussion ended
microsoft/TypeScript#4639
essentially JS is expecting BigInt and other types may be added someday and so no extra primitives will be added until T39 adds them
on a side note this regex proposal should it get implemented would be interesting
microsoft/TypeScript#6579
Feel free to obviously reject this change since the request is a stylistic one