forked from aws/aws-cdk
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(docs): clarify use of isOrganizationTrail (aws#21824)
If `isOrganizationTrail` is set to `true`, but the current AWS account is _not_ the management account then CloudFormation will throw an error. `You cannot configure or manage trails for an organization because this action requires being signed in with the management account.` Also remove the integration test that was added for this feature since in order to test this you would need access to an AWS organization management account _and_ access to create/delete an organization trail. ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
Showing
9 changed files
with
3 additions
and
424 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 0 additions & 116 deletions
116
...-cdk/aws-cloudtrail/test/cloudtrail.integ.snapshot/CloudtrailIntegTestStack.template.json
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
...est/cloudtrail.integ.snapshot/TrailIntegTestDefaultTestDeployAssertA42C24D1.template.json
This file was deleted.
Oops, something went wrong.
1 change: 0 additions & 1 deletion
1
packages/@aws-cdk/aws-cloudtrail/test/cloudtrail.integ.snapshot/cdk.out
This file was deleted.
Oops, something went wrong.
11 changes: 0 additions & 11 deletions
11
packages/@aws-cdk/aws-cloudtrail/test/cloudtrail.integ.snapshot/integ.json
This file was deleted.
Oops, something went wrong.
49 changes: 0 additions & 49 deletions
49
packages/@aws-cdk/aws-cloudtrail/test/cloudtrail.integ.snapshot/manifest.json
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.